[GitHub] [incubator-hudi] nsivabalan opened a new pull request #1091: [HUDI-389] Fixing Index look up to return partitions for a given key along with fileId with Global Bloom

[GitBox <gi...@apache.org>]

nsivabalan opened a new pull request #1091: [HUDI-389] Fixing Index look up to return partitions for a given key along with fileId with Global Bloom
URL: https://github.com/apache/incubator-hudi/pull/1091
 
 
   ## What is the purpose of the pull request
   
   Fixing Index look up to return partitions for a given key along with fileId with Global Bloom
   
   Use-case: 
   If a record is updated with a different partition than where it exists, with Global bloom, an exception is thrown as given [here](https://issues.apache.org/jira/browse/HUDI-389). This patch fixes the same. 
   
   Essentially in HoodieGlobaIndex#tagLocationBacktoRecords, each record is tagged with the right fileId and Partition and not just fileId (which was the case before this patch). In order to achieve this, I had to change the interface for IndexFileFilter from getMatchingFiles(String partitionPath, String recordKey) returning Set<FileId>s to returning Set<Pair<ParitionPath, fileId>>s. 
   
   ## Brief change log
   
     - Change interface of IndexfileFilter to return Set<Pair<PartitionPath, fileId>>
     - Fix Global Bloom to tag records with correct partitonPath from index look up and not from the passed in records(HoodieKey). 
   
   Tests:
   
   Added test in TestHoodieClientOnCopyOnWriteStorage#testUpsertToDiffPartitionGlobaIndex. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services