You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/07 09:46:54 UTC
[GitHub] [shardingsphere] jiangML opened a new pull request, #22722: Improve distsql transaction
jiangML opened a new pull request, #22722:
URL: https://github.com/apache/shardingsphere/pull/22722
Fixes #22721.
Changes proposed in this pull request:
- add check for `ALTER TRANSACTION RULE`
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22722: Add check for `ALTER TRANSACTION RULE`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22722:
URL: https://github.com/apache/shardingsphere/pull/22722#issuecomment-1340861284
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22722?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@7b924f5`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `55.17%`.
```diff
@@ Coverage Diff @@
## master #22722 +/- ##
=========================================
Coverage ? 49.40%
Complexity ? 2443
=========================================
Files ? 4107
Lines ? 57504
Branches ? 9850
=========================================
Hits ? 28409
Misses ? 26654
Partials ? 2441
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22722?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...eption/rule/InvalidRuleConfigurationException.java](https://codecov.io/gh/apache/shardingsphere/pull/22722/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kaXN0c3FsL2V4Y2VwdGlvbi9ydWxlL0ludmFsaWRSdWxlQ29uZmlndXJhdGlvbkV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ctory/ShardingSphereTransactionManagerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/22722/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYW5zYWN0aW9uL2FwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdHJhbnNhY3Rpb24vZmFjdG9yeS9TaGFyZGluZ1NwaGVyZVRyYW5zYWN0aW9uTWFuYWdlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...saction/xa/XAShardingSphereTransactionManager.java](https://codecov.io/gh/apache/shardingsphere/pull/22722/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYW5zYWN0aW9uL3R5cGUveGEvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdHJhbnNhY3Rpb24veGEvWEFTaGFyZGluZ1NwaGVyZVRyYW5zYWN0aW9uTWFuYWdlci5qYXZh) | `68.08% <0.00%> (ø)` | |
| [...a/manager/XATransactionManagerProviderFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/22722/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYW5zYWN0aW9uL3R5cGUveGEvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdHJhbnNhY3Rpb24veGEvbWFuYWdlci9YQVRyYW5zYWN0aW9uTWFuYWdlclByb3ZpZGVyRmFjdG9yeS5qYXZh) | `83.33% <0.00%> (ø)` | |
| [...r/update/AlterTransactionRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/22722/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYW5zYWN0aW9uL2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdHJhbnNhY3Rpb24vZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9BbHRlclRyYW5zYWN0aW9uUnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `80.64% <76.19%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #22722: Add check for `ALTER TRANSACTION RULE`
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #22722:
URL: https://github.com/apache/shardingsphere/pull/22722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org