You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Simon Nash (JIRA)" <tu...@ws.apache.org> on 2007/08/01 00:16:53 UTC
[jira] Created: (TUSCANY-1500) Many callback tests don't run
Many callback tests don't run
-----------------------------
Key: TUSCANY-1500
URL: https://issues.apache.org/jira/browse/TUSCANY-1500
Project: Tuscany
Issue Type: Bug
Components: Java SCA Core Runtime
Affects Versions: Java-SCA-Next
Environment: Windows XP
Reporter: Simon Nash
Assignee: Simon Nash
Fix For: Java-SCA-Next
The following itests are currently disabled in the build. If they are enabled by changing the name of the test class from xxxTest to xxxTestCase, they fail with various errors.
callback-api
callback-complex-type
callback-id
callback-set-callback
callback-set-conversation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1500) Many callback tests don't run
Posted by "Jean-Sebastien Delfino (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520665 ]
Jean-Sebastien Delfino commented on TUSCANY-1500:
-------------------------------------------------
I renamed these xxxTest.java to xxxTestFIXME.java to make clear that they need to be fixed.
> Many callback tests don't run
> -----------------------------
>
> Key: TUSCANY-1500
> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-Next
>
>
> The following itests are currently disabled in the build. If they are enabled by changing the name of the test class from xxxTest to xxxTestCase, they fail with various errors.
> callback-api
> callback-complex-type
> callback-id
> callback-set-callback
> callback-set-conversation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1500) Many callback tests don't run
Posted by "Simon Nash (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Nash updated TUSCANY-1500:
--------------------------------
Patch Info: [Patch Available]
> Many callback tests don't run
> -----------------------------
>
> Key: TUSCANY-1500
> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-Next
>
> Attachments: patch1
>
>
> The following itests are currently disabled in the build. If they are enabled by changing the name of the test class from xxxTest to xxxTestCase, they fail with various errors.
> callback-api
> callback-complex-type
> callback-id
> callback-set-callback
> callback-set-conversation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Updated: (TUSCANY-1500) Many callback tests don't run
Posted by Simon Nash <na...@hursley.ibm.com>.
I did a complete checkout and discovered that the patch is already
applied under r568837. (Thanks, Raymond.) I'll continue with the
next stage of fixing this JIRA now.
Simon
Simon Nash wrote:
> My apologies, I was working very late last night on this (always risky).
> I'll do a new checkout and find out why it doesn't apply. Actually I
> have made a couple of small extra tweaks this morning, so I'll probably
> resubmit a new patch including these that applies cleanly.
>
> Simon
>
> ant elder wrote:
>
>> The patch doesn't apply cleanly when i try it, maybe some line end
>> character
>> issue or something. Could you also attach a zip of the core and
>> callback-id
>> modules as well as the diff patch.
>>
>> ...ant
>>
>> On 8/23/07, Simon Nash <na...@hursley.ibm.com> wrote:
>>
>>> Please can someone apply this patch so the I can continue working on
>>> the other parts of this JIRA. Thanks.
>>>
>>> Simon
>>>
>>> Simon Nash (JIRA) wrote:
>>>
>>>> [
>>>
>>>
>>> https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>>>
>>>
>>>> Simon Nash updated TUSCANY-1500:
>>>> --------------------------------
>>>>
>>>> Attachment: patch2
>>>>
>>>> Here is patch2 for this JIRA. It enables the callback-id test in the
>>>
>>>
>>> build and gets it working. Here's a very brief summary of the changes in
>>> this patch.
>>>
>>>> 1. Rename CallBackIdTestCaseFIXME.java to CallBackIdTestCase.java.
>>>
>>>
>>> (NOTE: This must be done manually before applying the patch, which
>>> contains
>>> an update to CallBackIdTestCase.java.)
>>>
>>>> 2. Change the class name for the test from CallBackIdTestCaseFIXME to
>>>
>>>
>>> CallBackIdTestCase.
>>>
>>>> 3. Change the test code where it was not using the correct spec APIs.
>>>>
>>>> 4. Various runtime changes to enable the correct passing of the
>>>> callback
>>>
>>>
>>> ID on requests
>>>
>>>> I am looking at the other failing callback tests and I will post
>>>> further
>>>
>>>
>>> patches to get them working.
>>>
>>>>
>>>>> Many callback tests don't run
>>>>> -----------------------------
>>>>>
>>>>> Key: TUSCANY-1500
>>>>> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
>>>>> Project: Tuscany
>>>>> Issue Type: Bug
>>>>> Components: Java SCA Core Runtime
>>>>> Affects Versions: Java-SCA-Next
>>>>> Environment: Windows XP
>>>>> Reporter: Simon Nash
>>>>> Assignee: Simon Nash
>>>>> Fix For: Java-SCA-Next
>>>>>
>>>>> Attachments: patch1, patch2
>>>>>
>>>>>
>>>>> The following itests are currently disabled in the build. If they are
>>>
>>>
>>> enabled by changing the name of the test class from xxxTest to
>>> xxxTestCase,
>>> they fail with various errors.
>>>
>>>>> callback-api
>>>>> callback-complex-type
>>>>> callback-id
>>>>> callback-set-callback
>>>>> callback-set-conversation
>>>>
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>>> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>>>
>>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Updated: (TUSCANY-1500) Many callback tests don't run
Posted by Simon Nash <na...@hursley.ibm.com>.
My apologies, I was working very late last night on this (always risky).
I'll do a new checkout and find out why it doesn't apply. Actually I
have made a couple of small extra tweaks this morning, so I'll probably
resubmit a new patch including these that applies cleanly.
Simon
ant elder wrote:
> The patch doesn't apply cleanly when i try it, maybe some line end character
> issue or something. Could you also attach a zip of the core and callback-id
> modules as well as the diff patch.
>
> ...ant
>
> On 8/23/07, Simon Nash <na...@hursley.ibm.com> wrote:
>
>>Please can someone apply this patch so the I can continue working on
>>the other parts of this JIRA. Thanks.
>>
>> Simon
>>
>>Simon Nash (JIRA) wrote:
>>
>>> [
>>
>>https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>>
>>>Simon Nash updated TUSCANY-1500:
>>>--------------------------------
>>>
>>> Attachment: patch2
>>>
>>>Here is patch2 for this JIRA. It enables the callback-id test in the
>>
>>build and gets it working. Here's a very brief summary of the changes in
>>this patch.
>>
>>>1. Rename CallBackIdTestCaseFIXME.java to CallBackIdTestCase.java.
>>
>>(NOTE: This must be done manually before applying the patch, which contains
>>an update to CallBackIdTestCase.java.)
>>
>>>2. Change the class name for the test from CallBackIdTestCaseFIXME to
>>
>>CallBackIdTestCase.
>>
>>>3. Change the test code where it was not using the correct spec APIs.
>>>
>>>4. Various runtime changes to enable the correct passing of the callback
>>
>>ID on requests
>>
>>>I am looking at the other failing callback tests and I will post further
>>
>>patches to get them working.
>>
>>>
>>>>Many callback tests don't run
>>>>-----------------------------
>>>>
>>>> Key: TUSCANY-1500
>>>> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
>>>> Project: Tuscany
>>>> Issue Type: Bug
>>>> Components: Java SCA Core Runtime
>>>> Affects Versions: Java-SCA-Next
>>>> Environment: Windows XP
>>>> Reporter: Simon Nash
>>>> Assignee: Simon Nash
>>>> Fix For: Java-SCA-Next
>>>>
>>>> Attachments: patch1, patch2
>>>>
>>>>
>>>>The following itests are currently disabled in the build. If they are
>>
>>enabled by changing the name of the test class from xxxTest to xxxTestCase,
>>they fail with various errors.
>>
>>>> callback-api
>>>> callback-complex-type
>>>> callback-id
>>>> callback-set-callback
>>>> callback-set-conversation
>>>
>>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>>For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Updated: (TUSCANY-1500) Many callback tests don't run
Posted by Raymond Feng <en...@gmail.com>.
Hi,
I already applied it under 568837 last night.
Thanks,
Raymond
----- Original Message -----
From: "ant elder" <an...@gmail.com>
To: <tu...@ws.apache.org>
Sent: Thursday, August 23, 2007 3:46 AM
Subject: Re: [jira] Updated: (TUSCANY-1500) Many callback tests don't run
> The patch doesn't apply cleanly when i try it, maybe some line end
> character
> issue or something. Could you also attach a zip of the core and
> callback-id
> modules as well as the diff patch.
>
> ...ant
>
> On 8/23/07, Simon Nash <na...@hursley.ibm.com> wrote:
>>
>> Please can someone apply this patch so the I can continue working on
>> the other parts of this JIRA. Thanks.
>>
>> Simon
>>
>> Simon Nash (JIRA) wrote:
>> > [
>> https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>> >
>> > Simon Nash updated TUSCANY-1500:
>> > --------------------------------
>> >
>> > Attachment: patch2
>> >
>> > Here is patch2 for this JIRA. It enables the callback-id test in the
>> build and gets it working. Here's a very brief summary of the changes in
>> this patch.
>> >
>> > 1. Rename CallBackIdTestCaseFIXME.java to CallBackIdTestCase.java.
>> (NOTE: This must be done manually before applying the patch, which
>> contains
>> an update to CallBackIdTestCase.java.)
>> >
>> > 2. Change the class name for the test from CallBackIdTestCaseFIXME to
>> CallBackIdTestCase.
>> >
>> > 3. Change the test code where it was not using the correct spec APIs.
>> >
>> > 4. Various runtime changes to enable the correct passing of the
>> > callback
>> ID on requests
>> >
>> > I am looking at the other failing callback tests and I will post
>> > further
>> patches to get them working.
>> >
>> >
>> >>Many callback tests don't run
>> >>-----------------------------
>> >>
>> >> Key: TUSCANY-1500
>> >> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
>> >> Project: Tuscany
>> >> Issue Type: Bug
>> >> Components: Java SCA Core Runtime
>> >> Affects Versions: Java-SCA-Next
>> >> Environment: Windows XP
>> >> Reporter: Simon Nash
>> >> Assignee: Simon Nash
>> >> Fix For: Java-SCA-Next
>> >>
>> >> Attachments: patch1, patch2
>> >>
>> >>
>> >>The following itests are currently disabled in the build. If they are
>> enabled by changing the name of the test class from xxxTest to
>> xxxTestCase,
>> they fail with various errors.
>> >> callback-api
>> >> callback-complex-type
>> >> callback-id
>> >> callback-set-callback
>> >> callback-set-conversation
>> >
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Updated: (TUSCANY-1500) Many callback tests don't run
Posted by ant elder <an...@gmail.com>.
The patch doesn't apply cleanly when i try it, maybe some line end character
issue or something. Could you also attach a zip of the core and callback-id
modules as well as the diff patch.
...ant
On 8/23/07, Simon Nash <na...@hursley.ibm.com> wrote:
>
> Please can someone apply this patch so the I can continue working on
> the other parts of this JIRA. Thanks.
>
> Simon
>
> Simon Nash (JIRA) wrote:
> > [
> https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
> >
> > Simon Nash updated TUSCANY-1500:
> > --------------------------------
> >
> > Attachment: patch2
> >
> > Here is patch2 for this JIRA. It enables the callback-id test in the
> build and gets it working. Here's a very brief summary of the changes in
> this patch.
> >
> > 1. Rename CallBackIdTestCaseFIXME.java to CallBackIdTestCase.java.
> (NOTE: This must be done manually before applying the patch, which contains
> an update to CallBackIdTestCase.java.)
> >
> > 2. Change the class name for the test from CallBackIdTestCaseFIXME to
> CallBackIdTestCase.
> >
> > 3. Change the test code where it was not using the correct spec APIs.
> >
> > 4. Various runtime changes to enable the correct passing of the callback
> ID on requests
> >
> > I am looking at the other failing callback tests and I will post further
> patches to get them working.
> >
> >
> >>Many callback tests don't run
> >>-----------------------------
> >>
> >> Key: TUSCANY-1500
> >> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
> >> Project: Tuscany
> >> Issue Type: Bug
> >> Components: Java SCA Core Runtime
> >> Affects Versions: Java-SCA-Next
> >> Environment: Windows XP
> >> Reporter: Simon Nash
> >> Assignee: Simon Nash
> >> Fix For: Java-SCA-Next
> >>
> >> Attachments: patch1, patch2
> >>
> >>
> >>The following itests are currently disabled in the build. If they are
> enabled by changing the name of the test class from xxxTest to xxxTestCase,
> they fail with various errors.
> >> callback-api
> >> callback-complex-type
> >> callback-id
> >> callback-set-callback
> >> callback-set-conversation
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>
Re: [jira] Updated: (TUSCANY-1500) Many callback tests don't run
Posted by Simon Nash <na...@hursley.ibm.com>.
Please can someone apply this patch so the I can continue working on
the other parts of this JIRA. Thanks.
Simon
Simon Nash (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Simon Nash updated TUSCANY-1500:
> --------------------------------
>
> Attachment: patch2
>
> Here is patch2 for this JIRA. It enables the callback-id test in the build and gets it working. Here's a very brief summary of the changes in this patch.
>
> 1. Rename CallBackIdTestCaseFIXME.java to CallBackIdTestCase.java. (NOTE: This must be done manually before applying the patch, which contains an update to CallBackIdTestCase.java.)
>
> 2. Change the class name for the test from CallBackIdTestCaseFIXME to CallBackIdTestCase.
>
> 3. Change the test code where it was not using the correct spec APIs.
>
> 4. Various runtime changes to enable the correct passing of the callback ID on requests
>
> I am looking at the other failing callback tests and I will post further patches to get them working.
>
>
>>Many callback tests don't run
>>-----------------------------
>>
>> Key: TUSCANY-1500
>> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
>> Project: Tuscany
>> Issue Type: Bug
>> Components: Java SCA Core Runtime
>> Affects Versions: Java-SCA-Next
>> Environment: Windows XP
>> Reporter: Simon Nash
>> Assignee: Simon Nash
>> Fix For: Java-SCA-Next
>>
>> Attachments: patch1, patch2
>>
>>
>>The following itests are currently disabled in the build. If they are enabled by changing the name of the test class from xxxTest to xxxTestCase, they fail with various errors.
>> callback-api
>> callback-complex-type
>> callback-id
>> callback-set-callback
>> callback-set-conversation
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1500) Many callback tests don't run
Posted by "Simon Nash (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Nash updated TUSCANY-1500:
--------------------------------
Attachment: patch2
Here is patch2 for this JIRA. It enables the callback-id test in the build and gets it working. Here's a very brief summary of the changes in this patch.
1. Rename CallBackIdTestCaseFIXME.java to CallBackIdTestCase.java. (NOTE: This must be done manually before applying the patch, which contains an update to CallBackIdTestCase.java.)
2. Change the class name for the test from CallBackIdTestCaseFIXME to CallBackIdTestCase.
3. Change the test code where it was not using the correct spec APIs.
4. Various runtime changes to enable the correct passing of the callback ID on requests
I am looking at the other failing callback tests and I will post further patches to get them working.
> Many callback tests don't run
> -----------------------------
>
> Key: TUSCANY-1500
> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-Next
>
> Attachments: patch1, patch2
>
>
> The following itests are currently disabled in the build. If they are enabled by changing the name of the test class from xxxTest to xxxTestCase, they fail with various errors.
> callback-api
> callback-complex-type
> callback-id
> callback-set-callback
> callback-set-conversation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1500) Many callback tests don't run
Posted by "Simon Nash (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Nash updated TUSCANY-1500:
--------------------------------
Attachment: patch5
Here is patch 5 for this JIRA. It enables itest/callback-set-conversation in the build and gets it working. Some further cleanup of this test case is needed to remove workarounds for current limitations of the core runtime.
Here's a brief summary of the changes in this patch.
1. Rename CallBackSetCallbackConvTestCaseFIXME.java to CallBackSetCallbackConvTestCase.java. (NOTE: This must be done manually before applying the patch, which contains an update to CallBackSetCallbackConvTestCase.java.)
2. Change the class name for the test from CallBackSetCallbackConvTestCaseFIXME to CallBackSetCallbackConvTestCase.
3. Change the test code where it was not using the spec APIs correctly. (In some places, the code contains "FIXME" workarounds because of current limitations with the core runtime.)
4. Change the runtime to enable stateful callbacks to be made to a callback object that isn't a service reference (see section 1.6.7.5 of the Java Annotations and APIs spec). This requires registering the callback object with the conversational scope container so that it can be located when the client component receives the callback.
I will continue to work on the core runtime changes that are needed in order to remove the current workarounds in this test case.
> Many callback tests don't run
> -----------------------------
>
> Key: TUSCANY-1500
> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-1.0
>
> Attachments: ImplementationProvider2.java, patch1, patch2, patch3, patch4, patch5
>
>
> The following itests are currently disabled in the build. If they are enabled by changing the name of the test class from xxxTest to xxxTestCase, they fail with various errors.
> callback-api
> callback-complex-type
> callback-id
> callback-set-callback
> callback-set-conversation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Updated: (TUSCANY-1500) Many callback tests don't run
Posted by Simon Nash <na...@hursley.ibm.com>.
Thanks very much Raymond, and thanks for the improvements to my patch.
I have one minor comment on the changes. In CallbackInterfaceInterceptor
the invoke() method is as follows:
public Message invoke(Message msg) {
CallableReference<?> callableReference = msg.getCallableReference();
if (callableReference instanceof ServiceReference) {
if (((ServiceReference<?>)callableReference).getCallback() == null) {
throw new NoRegisteredCallbackException("Callback target does not implement the callback interface");
}
}
return next.invoke(msg);
}
If the callableReference is not an instance of ServiceReference, then it
does not have a callback object and so I would expect the exception to
be thrown. Something like:
public Message invoke(Message msg) {
CallableReference<?> callableReference = msg.getCallableReference();
if (callableReference instanceof ServiceReference &&
((ServiceReference<?>)callableReference).getCallback() != null) {
return next.invoke(msg);
} else {
throw new NoRegisteredCallbackException("Callback target does not implement the callback interface");
}
}
Simon
Raymond Feng wrote:
> Hi,
>
> I applied the patch4 with the following changes:
>
> 1) Remove ImplementationProvider2 and use
> RuntimeWireProcessorExtensionPoint instead to add the interceptor
> 2) Keep the CallableReference to the Message instead of a flag for the
> callback object
> 3) Use InterfaceContractMapper to test if the source implementation
> "implements" the callback interface
>
> Thanks,
> Raymond
>
> ----- Original Message ----- From: "Simon Nash (JIRA)"
> <tu...@ws.apache.org>
> To: <tu...@ws.apache.org>
> Sent: Thursday, August 30, 2007 1:26 AM
> Subject: [jira] Updated: (TUSCANY-1500) Many callback tests don't run
>
>
>>
>> [
>> https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Simon Nash updated TUSCANY-1500:
>> --------------------------------
>>
>> Attachment: patch4
>>
>> Here is patch4 for this JIRA. It completes the work needed to get the
>> callback-set-callback test fully working, as well as doing some minor
>> cleanup on the test case. In the core runtime it adds the check for
>> NoRegisteredCallbackException as required by section 1.6.7.5 of the
>> Java Common Annotations and APIs spec.
>>
>> In addition to the changes in this patch, the following new file (also
>> attached to this JIRA) must be added:
>>
>>
>> sca\modules\core-spi\src\main\java\org\apache\tuscany\sca\provider\ImplementationProvider2.java
>>
>>
>> I am looking at the other failing callback tests and I will post
>> further patches to get them working.
>>
>>
>>> Many callback tests don't run
>>> -----------------------------
>>>
>>> Key: TUSCANY-1500
>>> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
>>> Project: Tuscany
>>> Issue Type: Bug
>>> Components: Java SCA Core Runtime
>>> Affects Versions: Java-SCA-Next
>>> Environment: Windows XP
>>> Reporter: Simon Nash
>>> Assignee: Simon Nash
>>> Fix For: Java-SCA-1.0
>>>
>>> Attachments: ImplementationProvider2.java, patch1, patch2,
>>> patch3, patch4
>>>
>>>
>>> The following itests are currently disabled in the build. If they
>>> are enabled by changing the name of the test class from xxxTest to
>>> xxxTestCase, they fail with various errors.
>>> callback-api
>>> callback-complex-type
>>> callback-id
>>> callback-set-callback
>>> callback-set-conversation
>>
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Updated: (TUSCANY-1500) Many callback tests don't run
Posted by Raymond Feng <en...@gmail.com>.
Hi,
I applied the patch4 with the following changes:
1) Remove ImplementationProvider2 and use RuntimeWireProcessorExtensionPoint
instead to add the interceptor
2) Keep the CallableReference to the Message instead of a flag for the
callback object
3) Use InterfaceContractMapper to test if the source implementation
"implements" the callback interface
Thanks,
Raymond
----- Original Message -----
From: "Simon Nash (JIRA)" <tu...@ws.apache.org>
To: <tu...@ws.apache.org>
Sent: Thursday, August 30, 2007 1:26 AM
Subject: [jira] Updated: (TUSCANY-1500) Many callback tests don't run
>
> [
> https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Simon Nash updated TUSCANY-1500:
> --------------------------------
>
> Attachment: patch4
>
> Here is patch4 for this JIRA. It completes the work needed to get the
> callback-set-callback test fully working, as well as doing some minor
> cleanup on the test case. In the core runtime it adds the check for
> NoRegisteredCallbackException as required by section 1.6.7.5 of the Java
> Common Annotations and APIs spec.
>
> In addition to the changes in this patch, the following new file (also
> attached to this JIRA) must be added:
>
>
> sca\modules\core-spi\src\main\java\org\apache\tuscany\sca\provider\ImplementationProvider2.java
>
> I am looking at the other failing callback tests and I will post further
> patches to get them working.
>
>
>> Many callback tests don't run
>> -----------------------------
>>
>> Key: TUSCANY-1500
>> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
>> Project: Tuscany
>> Issue Type: Bug
>> Components: Java SCA Core Runtime
>> Affects Versions: Java-SCA-Next
>> Environment: Windows XP
>> Reporter: Simon Nash
>> Assignee: Simon Nash
>> Fix For: Java-SCA-1.0
>>
>> Attachments: ImplementationProvider2.java, patch1, patch2,
>> patch3, patch4
>>
>>
>> The following itests are currently disabled in the build. If they are
>> enabled by changing the name of the test class from xxxTest to
>> xxxTestCase, they fail with various errors.
>> callback-api
>> callback-complex-type
>> callback-id
>> callback-set-callback
>> callback-set-conversation
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1500) Many callback tests don't run
Posted by "Simon Nash (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Nash updated TUSCANY-1500:
--------------------------------
Attachment: patch4
Here is patch4 for this JIRA. It completes the work needed to get the callback-set-callback test fully working, as well as doing some minor cleanup on the test case. In the core runtime it adds the check for NoRegisteredCallbackException as required by section 1.6.7.5 of the Java Common Annotations and APIs spec.
In addition to the changes in this patch, the following new file (also attached to this JIRA) must be added:
sca\modules\core-spi\src\main\java\org\apache\tuscany\sca\provider\ImplementationProvider2.java
I am looking at the other failing callback tests and I will post further patches to get them working.
> Many callback tests don't run
> -----------------------------
>
> Key: TUSCANY-1500
> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-1.0
>
> Attachments: ImplementationProvider2.java, patch1, patch2, patch3, patch4
>
>
> The following itests are currently disabled in the build. If they are enabled by changing the name of the test class from xxxTest to xxxTestCase, they fail with various errors.
> callback-api
> callback-complex-type
> callback-id
> callback-set-callback
> callback-set-conversation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Closed: (TUSCANY-1500) Many callback tests don't run
Posted by "ant elder (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ant elder closed TUSCANY-1500.
------------------------------
Resolution: Fixed
As far as i can tell these patches have now been applied so closing this.
Thanks for the fixes.
> Many callback tests don't run
> -----------------------------
>
> Key: TUSCANY-1500
> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-1.0
>
> Attachments: ImplementationProvider2.java, patch1, patch2, patch3, patch4, patch5
>
>
> The following itests are currently disabled in the build. If they are enabled by changing the name of the test class from xxxTest to xxxTestCase, they fail with various errors.
> callback-api
> callback-complex-type
> callback-id
> callback-set-callback
> callback-set-conversation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Reopened: (TUSCANY-1500) Many callback tests don't run
Posted by "Simon Nash (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Nash reopened TUSCANY-1500:
---------------------------------
Assignee: Simon Nash (was: Raymond Feng)
Thanks for applying patch1. I'm reopening this JIRA because there is further work needed to get the remaining callback tests to run.
> Many callback tests don't run
> -----------------------------
>
> Key: TUSCANY-1500
> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-Next
>
> Attachments: patch1
>
>
> The following itests are currently disabled in the build. If they are enabled by changing the name of the test class from xxxTest to xxxTestCase, they fail with various errors.
> callback-api
> callback-complex-type
> callback-id
> callback-set-callback
> callback-set-conversation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1500) Many callback tests don't run
Posted by "Simon Nash (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Nash updated TUSCANY-1500:
--------------------------------
Attachment: patch3
Here is patch3 for this JIRA. It enables the callback-set-callback test in the build and gets it working. One small piece is still left to do for this test (adding a missing error check) and I will do this after we have cut the branch for the 0.99 release.
Here's a very brief summary of the changes in this patch.
1. Rename CallBackSetCallbackTestCaseFIXME.java to CallBackSetCallbackTestCase.java. (NOTE: This must be done manually before applying the patch, which contains an update to CallBackSetCallbackTestCase.java.)
2. Change the class name for the test from CallBackSetCallbackTestCaseFIXME to CallBackSetCallbackTestCase.
3. Change the test code where it was not using the spec APIs correctly.
4. Various runtime changes to enable the correct passing of the callback object on requests and checking for some error cases. These include changing RequestContextImpl.getServiceReference() to return a CallableReference as required by the spec, as this change was needed to get the final part of the test to pass
The outstanding item still to be done for this test case is to add the required error check for invoking a service with a callback when the sender does not implement the callback object and there is no callback object set. For now I have commented out the line in the test case that tests the diagnostic for this that is mandated by the spec.
I am looking at the other failing callback tests and I will post further patches to get them working.
> Many callback tests don't run
> -----------------------------
>
> Key: TUSCANY-1500
> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-Next
>
> Attachments: patch1, patch2, patch3
>
>
> The following itests are currently disabled in the build. If they are enabled by changing the name of the test class from xxxTest to xxxTestCase, they fail with various errors.
> callback-api
> callback-complex-type
> callback-id
> callback-set-callback
> callback-set-conversation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1500) Many callback tests don't run
Posted by "Simon Nash (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Nash updated TUSCANY-1500:
--------------------------------
Attachment: ImplementationProvider2.java
This file is part of patch 4. It must be added to the repository before applying the clanges in the patch4 file.
> Many callback tests don't run
> -----------------------------
>
> Key: TUSCANY-1500
> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-1.0
>
> Attachments: ImplementationProvider2.java, patch1, patch2, patch3
>
>
> The following itests are currently disabled in the build. If they are enabled by changing the name of the test class from xxxTest to xxxTestCase, they fail with various errors.
> callback-api
> callback-complex-type
> callback-id
> callback-set-callback
> callback-set-conversation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1500) Many callback tests don't run
Posted by "Simon Nash (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Nash updated TUSCANY-1500:
--------------------------------
Attachment: patch1
Here is patch1 for this JIRA. It enables the callback-api test in the build and gets it working. Here's a summary of the changes in this patch.
1. Rename CallBackApiTestCaseFIXME.java to CallBackApiTestCase.java. (NOTE: This must be done manually before applying the patch, which contains an update to CallBackApiTestCase.java.)
2. Change the class name for the test from CallBackApiTestCaseFIXME to CallBackApiTestCase.
3. Change the test code that gets the callable reference to use the correct spec APIs.
4. Move the code in JDKCallbackInvocationHandler that clones and binds the selected dynamic wire into CallbackWireObjectFactory so that it can be executed when callable references are created as when as when callback invocations are made.
5. Restore the factory.resolveTarget() call in RequestContextImpl.getCallbackReference() that was commented out. This selects a wire and endpoint for the callback so that this becomes part of the callable reference.
6. Make RequestContextImpl.getCallbackReference() return a CallableReferenceImpl object instead of a service reference. (This was being done previously but was inadvertently changed by an overlapping update.)
7. Restrict the constructors in CallableReferenceImpl to protected as we don't want to open up direct instantiation of these objects to application code.
I am looking at the other failing callback tests and I will post further patches to get them working.
> Many callback tests don't run
> -----------------------------
>
> Key: TUSCANY-1500
> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-Next
>
> Attachments: patch1
>
>
> The following itests are currently disabled in the build. If they are enabled by changing the name of the test class from xxxTest to xxxTestCase, they fail with various errors.
> callback-api
> callback-complex-type
> callback-id
> callback-set-callback
> callback-set-conversation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1500) Many callback tests don't run
Posted by "Jean-Sebastien Delfino (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Sebastien Delfino updated TUSCANY-1500:
--------------------------------------------
Fix Version/s: (was: Java-SCA-Next)
Java-SCA-1.0
> Many callback tests don't run
> -----------------------------
>
> Key: TUSCANY-1500
> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-1.0
>
> Attachments: patch1, patch2, patch3
>
>
> The following itests are currently disabled in the build. If they are enabled by changing the name of the test class from xxxTest to xxxTestCase, they fail with various errors.
> callback-api
> callback-complex-type
> callback-id
> callback-set-callback
> callback-set-conversation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Resolved: (TUSCANY-1500) Many callback tests don't run
Posted by "Raymond Feng (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raymond Feng resolved TUSCANY-1500.
-----------------------------------
Resolution: Fixed
Patch applied. Thanks.
> Many callback tests don't run
> -----------------------------
>
> Key: TUSCANY-1500
> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Simon Nash
> Assignee: Raymond Feng
> Fix For: Java-SCA-Next
>
> Attachments: patch1
>
>
> The following itests are currently disabled in the build. If they are enabled by changing the name of the test class from xxxTest to xxxTestCase, they fail with various errors.
> callback-api
> callback-complex-type
> callback-id
> callback-set-callback
> callback-set-conversation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Assigned: (TUSCANY-1500) Many callback tests don't run
Posted by "Raymond Feng (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raymond Feng reassigned TUSCANY-1500:
-------------------------------------
Assignee: Raymond Feng (was: Simon Nash)
> Many callback tests don't run
> -----------------------------
>
> Key: TUSCANY-1500
> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Simon Nash
> Assignee: Raymond Feng
> Fix For: Java-SCA-Next
>
> Attachments: patch1
>
>
> The following itests are currently disabled in the build. If they are enabled by changing the name of the test class from xxxTest to xxxTestCase, they fail with various errors.
> callback-api
> callback-complex-type
> callback-id
> callback-set-callback
> callback-set-conversation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org