You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/01 02:00:16 UTC
[GitHub] [apisix-dashboard] zzzdong opened a new pull request #1701: fix: user login request should remove its own prefix option
zzzdong opened a new pull request #1701:
URL: https://github.com/apache/apisix-dashboard/pull/1701
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ *] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Please update this section with detailed description.
**Related issues**
**Checklist:**
- [ *] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ *] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1701: fix: user login request should remove its own prefix option
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1701:
URL: https://github.com/apache/apisix-dashboard/pull/1701#discussion_r605350880
##########
File path: web/src/pages/User/components/LoginMethodPassword.tsx
##########
@@ -105,7 +105,6 @@ const LoginMethodPassword: UserModule.LoginMethod = {
const result = await request('/apisix/admin/user/login', {
method: 'POST',
requestType: 'json',
- prefix: '',
Review comment:
ok!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1701: fix: user login request should remove its own prefix option
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1701:
URL: https://github.com/apache/apisix-dashboard/pull/1701#discussion_r605333293
##########
File path: web/src/pages/User/components/LoginMethodPassword.tsx
##########
@@ -105,7 +105,6 @@ const LoginMethodPassword: UserModule.LoginMethod = {
const result = await request('/apisix/admin/user/login', {
method: 'POST',
requestType: 'json',
- prefix: '',
Review comment:
@zzzdong Hi, if we have this prefix, what will happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1701: fix: user login request should remove its own prefix option
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1701:
URL: https://github.com/apache/apisix-dashboard/pull/1701#issuecomment-811587203
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=h1) Report
> Merging [#1701](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=desc) (f078bf1) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/846f2c14d2343d9aa79dbe332e699850c92fe161?el=desc) (846f2c1) will **decrease** coverage by `1.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1701 +/- ##
==========================================
- Coverage 72.61% 71.40% -1.22%
==========================================
Files 133 47 -86
Lines 5741 3126 -2615
Branches 668 0 -668
==========================================
- Hits 4169 2232 -1937
+ Misses 1329 650 -679
- Partials 243 244 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `62.15% <ø> (-0.07%)` | :arrow_down: |
| backend-e2e-test-ginkgo | `48.43% <ø> (+0.06%)` | :arrow_up: |
| backend-unit-test | `52.29% <ø> (ø)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `43.63% <0.00%> (-1.82%)` | :arrow_down: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `87.95% <0.00%> (ø)` | |
| [web/src/pages/Upstream/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS90cmFuc2Zvcm0udHM=) | | |
| [web/src/services/user.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-d2ViL3NyYy9zZXJ2aWNlcy91c2VyLnRz) | | |
| [web/src/pages/Setting/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TZXR0aW5nL3NlcnZpY2UudHM=) | | |
| [.../components/PluginOrchestration/DrawPluginStyle.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vRHJhd1BsdWdpblN0eWxlLnRz) | | |
| [web/src/pages/Setting/Setting.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TZXR0aW5nL1NldHRpbmcudHN4) | | |
| [web/src/pages/Service/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0xpc3QudHN4) | | |
| [web/src/access.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-d2ViL3NyYy9hY2Nlc3MudHM=) | | |
| [web/src/pages/PluginTemplate/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9zZXJ2aWNlLnRz) | | |
| ... and [77 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=footer). Last update [846f2c1...f078bf1](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1701: fix: user login request should remove its own prefix option
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1701:
URL: https://github.com/apache/apisix-dashboard/pull/1701#issuecomment-811587203
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=h1) Report
> Merging [#1701](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=desc) (f078bf1) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/846f2c14d2343d9aa79dbe332e699850c92fe161?el=desc) (846f2c1) will **decrease** coverage by `24.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1701 +/- ##
===========================================
- Coverage 72.61% 47.79% -24.83%
===========================================
Files 133 47 -86
Lines 5741 3126 -2615
Branches 668 0 -668
===========================================
- Hits 4169 1494 -2675
- Misses 1329 1373 +44
- Partials 243 259 +16
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `47.79% <ø> (-14.43%)` | :arrow_down: |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | `15.00% <0.00%> (-85.00%)` | :arrow_down: |
| [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `13.88% <0.00%> (-80.56%)` | :arrow_down: |
| [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `23.80% <0.00%> (-76.20%)` | :arrow_down: |
| [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `5.55% <0.00%> (-70.38%)` | :arrow_down: |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `12.04% <0.00%> (-61.26%)` | :arrow_down: |
| [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `31.42% <0.00%> (-59.29%)` | :arrow_down: |
| [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `33.33% <0.00%> (-57.15%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `41.73% <0.00%> (-50.44%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [106 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=footer). Last update [846f2c1...f078bf1](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1701: fix: user login request should remove its own prefix option
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #1701:
URL: https://github.com/apache/apisix-dashboard/pull/1701#discussion_r611359655
##########
File path: web/src/pages/User/components/LoginMethodPassword.tsx
##########
@@ -102,10 +102,9 @@ const LoginMethodPassword: UserModule.LoginMethod = {
submit: async ({ username, password }) => {
if (username !== '' && password !== '') {
try {
- const result = await request('/apisix/admin/user/login', {
+ const result = await request('/user/login', {
Review comment:
Do we need to update related test cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1701: fix: user login request should remove its own prefix option
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1701:
URL: https://github.com/apache/apisix-dashboard/pull/1701#issuecomment-811587203
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=h1) Report
> Merging [#1701](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=desc) (f078bf1) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/846f2c14d2343d9aa79dbe332e699850c92fe161?el=desc) (846f2c1) will **decrease** coverage by `10.46%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1701 +/- ##
===========================================
- Coverage 72.61% 62.15% -10.47%
===========================================
Files 133 47 -86
Lines 5741 3126 -2615
Branches 668 0 -668
===========================================
- Hits 4169 1943 -2226
+ Misses 1329 870 -459
- Partials 243 313 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `62.15% <ø> (-0.07%)` | :arrow_down: |
| backend-e2e-test-ginkgo | `48.43% <ø> (+0.06%)` | :arrow_up: |
| backend-unit-test | `?` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `47.22% <0.00%> (-30.56%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `62.60% <0.00%> (-29.57%)` | :arrow_down: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `58.43% <0.00%> (-29.52%)` | :arrow_down: |
| [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `64.51% <0.00%> (-19.36%)` | :arrow_down: |
| [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | `59.57% <0.00%> (-18.09%)` | :arrow_down: |
| [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `44.82% <0.00%> (-13.80%)` | :arrow_down: |
| [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `77.14% <0.00%> (-13.58%)` | :arrow_down: |
| ... and [98 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=footer). Last update [846f2c1...f078bf1](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1701: fix: user login request should remove its own prefix option
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1701:
URL: https://github.com/apache/apisix-dashboard/pull/1701#discussion_r607407406
##########
File path: web/src/pages/User/components/LoginMethodPassword.tsx
##########
@@ -105,7 +105,6 @@ const LoginMethodPassword: UserModule.LoginMethod = {
const result = await request('/apisix/admin/user/login', {
method: 'POST',
requestType: 'json',
- prefix: '',
Review comment:
it seems that you have to modify the request url to `/user/login` at the same time, otherwise, `/apisix/admin` will appear twice under the global prefix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zzzdong commented on a change in pull request #1701: fix: user login request should remove its own prefix option
Posted by GitBox <gi...@apache.org>.
zzzdong commented on a change in pull request #1701:
URL: https://github.com/apache/apisix-dashboard/pull/1701#discussion_r607427338
##########
File path: web/src/pages/User/components/LoginMethodPassword.tsx
##########
@@ -105,7 +105,6 @@ const LoginMethodPassword: UserModule.LoginMethod = {
const result = await request('/apisix/admin/user/login', {
method: 'POST',
requestType: 'json',
- prefix: '',
Review comment:
oops, I will remove that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1701: fix: user login request should remove its own prefix option
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1701:
URL: https://github.com/apache/apisix-dashboard/pull/1701#discussion_r613141485
##########
File path: web/src/pages/User/components/LoginMethodPassword.tsx
##########
@@ -102,10 +102,9 @@ const LoginMethodPassword: UserModule.LoginMethod = {
submit: async ({ username, password }) => {
if (username !== '' && password !== '') {
try {
- const result = await request('/apisix/admin/user/login', {
+ const result = await request('/user/login', {
Review comment:
request will handle this :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1701: fix: user login request should remove its own prefix option
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1701:
URL: https://github.com/apache/apisix-dashboard/pull/1701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1701: fix: user login request should remove its own prefix option
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1701:
URL: https://github.com/apache/apisix-dashboard/pull/1701#issuecomment-811587203
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=h1) Report
> Merging [#1701](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=desc) (c70d8e6) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/846f2c14d2343d9aa79dbe332e699850c92fe161?el=desc) (846f2c1) will **decrease** coverage by `20.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1701 +/- ##
===========================================
- Coverage 72.61% 52.29% -20.33%
===========================================
Files 133 38 -95
Lines 5741 2660 -3081
Branches 668 0 -668
===========================================
- Hits 4169 1391 -2778
+ Misses 1329 1081 -248
+ Partials 243 188 -55
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `52.29% <ø> (ø)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
| [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: |
| [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| ... and [118 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1701/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=footer). Last update [846f2c1...c70d8e6](https://codecov.io/gh/apache/apisix-dashboard/pull/1701?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zzzdong commented on a change in pull request #1701: fix: user login request should remove its own prefix option
Posted by GitBox <gi...@apache.org>.
zzzdong commented on a change in pull request #1701:
URL: https://github.com/apache/apisix-dashboard/pull/1701#discussion_r605349393
##########
File path: web/src/pages/User/components/LoginMethodPassword.tsx
##########
@@ -105,7 +105,6 @@ const LoginMethodPassword: UserModule.LoginMethod = {
const result = await request('/apisix/admin/user/login', {
method: 'POST',
requestType: 'json',
- prefix: '',
Review comment:
It will replace the global [`RequestConfig.prefix`](https://github.com/apache/apisix-dashboard/blob/88f323285f2bdbafca027da9aef357b2e3eb4008/web/src/app.tsx#L59)，which unexpected when use dashboard under subpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org