[GitHub] spark pull request: [java8API] SPARK-964 Investigate the potential...

[JoshRosen <gi...@git.apache.org>]

Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17#discussion_r57963233
  
    --- Diff: extras/java8-tests/pom.xml ---
    @@ -0,0 +1,151 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +~ Licensed to the Apache Software Foundation (ASF) under one or more
    +~ contributor license agreements.  See the NOTICE file distributed with
    +~ this work for additional information regarding copyright ownership.
    +~ The ASF licenses this file to You under the Apache License, Version 2.0
    +~ (the "License"); you may not use this file except in compliance with
    +~ the License.  You may obtain a copy of the License at
    +~
    +~    http://www.apache.org/licenses/LICENSE-2.0
    +~
    +~ Unless required by applicable law or agreed to in writing, software
    +~ distributed under the License is distributed on an "AS IS" BASIS,
    +~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +~ See the License for the specific language governing permissions and
    +~ limitations under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +  <modelVersion>4.0.0</modelVersion>
    +  <parent>
    +    <groupId>org.apache.spark</groupId>
    +    <artifactId>spark-parent</artifactId>
    +    <version>1.0.0-SNAPSHOT</version>
    +    <relativePath>../../pom.xml</relativePath>
    +  </parent>
    +
    +  <groupId>org.apache.spark</groupId>
    +  <artifactId>java8-tests_2.10</artifactId>
    +  <packaging>pom</packaging>
    +  <name>Spark Project Java8 Tests POM</name>
    +  
    +  <dependencies>
    +    <dependency>
    +      <groupId>org.apache.spark</groupId>
    +      <artifactId>spark-core_${scala.binary.version}</artifactId>
    +      <version>${project.version}</version>
    +    </dependency>
    +    <dependency>
    +      <groupId>org.apache.spark</groupId>
    +      <artifactId>spark-streaming_${scala.binary.version}</artifactId>
    +      <version>${project.version}</version>
    +    </dependency>
    +    <dependency>
    +      <groupId>org.apache.spark</groupId>
    +      <artifactId>spark-streaming_${scala.binary.version}</artifactId>
    +      <version>${project.version}</version>
    +      <type>test-jar</type>
    +    </dependency>
    +    <dependency>
    +      <groupId>com.novocode</groupId>
    +      <artifactId>junit-interface</artifactId>
    +      <scope>test</scope>
    +    </dependency>
    +    <dependency>
    +      <groupId>org.scalatest</groupId>
    +      <artifactId>scalatest_${scala.binary.version}</artifactId>
    +      <scope>test</scope>
    +    </dependency>
    +  </dependencies>
    +
    +  <profiles>
    +    <profile>
    +      <id>java8-tests</id>
    +    </profile>
    +  </profiles>
    +  <build>
    +    <plugins>
    +      <plugin>
    +        <groupId>org.apache.maven.plugins</groupId>
    +        <artifactId>maven-surefire-plugin</artifactId>
    +        <executions>
    +          <execution>
    +            <id>test</id>
    +            <goals>
    +              <goal>test</goal>
    +            </goals>
    +          </execution>
    +        </executions>
    +        <configuration>
    +          <systemPropertyVariables>
    +            <!-- For some reason surefire isn't setting this log4j file on the
    +                 test classpath automatically. So we add it manually. -->
    +            <log4j.configuration>
    +              file:src/test/resources/log4j.properties
    +            </log4j.configuration>
    +          </systemPropertyVariables>
    +          <skipTests>false</skipTests>
    +          <includes>
    +            <include>**/Suite*.java</include>
    +            <include>**/*Suite.java</include>
    +          </includes>
    +        </configuration>
    +      </plugin>
    +      <plugin>
    +        <groupId>org.apache.maven.plugins</groupId>
    +        <artifactId>maven-compiler-plugin</artifactId>
    +        <executions>
    +          <execution>
    +            <id>test-compile-first</id>
    +            <phase>process-test-resources</phase>
    +            <goals>
    +              <goal>testCompile</goal>
    +            </goals>
    +          </execution>
    +        </executions>
    +        <configuration>
    +          <fork>true</fork>
    +          <verbose>true</verbose>
    +          <forceJavacCompilerUse>true</forceJavacCompilerUse>
    +          <source>1.8</source>
    +          <compilerVersion>1.8</compilerVersion>
    +          <target>1.8</target>
    +          <encoding>UTF-8</encoding>
    +          <maxmem>1024m</maxmem>
    +        </configuration>
    +      </plugin>
    +      <plugin>
    +        <!-- disabled -->
    --- End diff --
    
    Why did this POM's build configuration have to be so complicated? Why can't you just override the `javacOptions` configuration in the `scala-maven-plugin` and then just inherit the rest of the configuration?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org