You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kfaraz (via GitHub)" <gi...@apache.org> on 2025/02/14 06:31:28 UTC
[PR] Add log and metric for overlord segment cache (druid)
kfaraz opened a new pull request, #17728:
URL: https://github.com/apache/druid/pull/17728
Add metric
- `segment/metadataCache/transactions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Add log and metric for overlord segment cache (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz merged PR #17728:
URL: https://github.com/apache/druid/pull/17728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Add log and metric for overlord segment cache (druid)
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe commented on code in PR #17728:
URL: https://github.com/apache/druid/pull/17728#discussion_r1955695190
##########
server/src/main/java/org/apache/druid/metadata/segment/cache/Metric.java:
##########
@@ -47,6 +47,11 @@ private Metric()
// CACHE METRICS
private static final String METRIC_NAME_PREFIX = "segment/metadataCache/";
+ /**
+ * Number of transactions performed on the cache for a datasource.
+ */
+ public static final String TRANSACTION_COUNT = "transactions";
Review Comment:
Please add the metrics in the metrics.md doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Add log and metric for overlord segment cache (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on code in PR #17728:
URL: https://github.com/apache/druid/pull/17728#discussion_r1955770073
##########
server/src/main/java/org/apache/druid/metadata/segment/cache/Metric.java:
##########
@@ -47,6 +47,11 @@ private Metric()
// CACHE METRICS
private static final String METRIC_NAME_PREFIX = "segment/metadataCache/";
+ /**
+ * Number of transactions performed on the cache for a datasource.
+ */
+ public static final String TRANSACTION_COUNT = "transactions";
Review Comment:
added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org