You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/31 07:48:56 UTC
[GitHub] [arrow-datafusion] Jimexist opened a new pull request #453: use prettier check in CI
Jimexist opened a new pull request #453:
URL: https://github.com/apache/arrow-datafusion/pull/453
# Which issue does this PR close?
Closes #415
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #453: use prettier check in CI
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #453:
URL: https://github.com/apache/arrow-datafusion/pull/453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #453: use prettier check in CI
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #453:
URL: https://github.com/apache/arrow-datafusion/pull/453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #453: use prettier check in CI
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #453:
URL: https://github.com/apache/arrow-datafusion/pull/453#issuecomment-853366263
@Jimexist this PR has some conflicts -- would it be possible to rebase it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #453: use prettier check in CI
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #453:
URL: https://github.com/apache/arrow-datafusion/pull/453#discussion_r643383510
##########
File path: .github/workflows/dev.yml
##########
@@ -37,3 +36,17 @@ jobs:
run: pip install -e dev/archery[docker]
- name: Lint
run: archery lint --rat
+
+ prettier:
+ name: Use prettier to check formatting of documents
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - uses: actions/setup-node@v2
+ with:
+ node-version: "14"
+ - name: Prettier check
+ run: |
+ # if you encounter error, try rerun the command below with --write instead of --check
Review comment:
👍 thank you for the comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org