You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2025/10/14 03:24:28 UTC
[PR] [fix](search) fix mow support for search function [doris]
airborne12 opened a new pull request, #56927:
URL: https://github.com/apache/doris/pull/56927
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](search) fix mow support for search function [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56927:
URL: https://github.com/apache/doris/pull/56927#issuecomment-3401710498
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](search) fix mow support for search function [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 merged PR #56927:
URL: https://github.com/apache/doris/pull/56927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](search) fix mow support for search function [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #56927:
URL: https://github.com/apache/doris/pull/56927#issuecomment-3400240734
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](search) fix mow support for search function [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #56927:
URL: https://github.com/apache/doris/pull/56927#discussion_r2428004689
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/CheckSearchUsage.java:
##########
@@ -127,4 +131,17 @@ private boolean containsSearchExpression(Expression expression) {
}
return false;
}
+
+ private boolean isSingleTableScanPipeline(Plan plan) {
+ Plan current = plan;
+ while (true) {
+ if (current instanceof LogicalOlapScan) {
+ return true;
+ }
+ if (current.arity() != 1) {
+ return false;
+ }
+ current = current.child(0);
Review Comment:
This method can result in an infinite loop or null pointer exception. The while loop lacks a null check for `current.child(0)` and has no termination condition if the plan tree doesn't contain a `LogicalOlapScan`. Add a null check and ensure proper termination.
```suggestion
Plan next = current.child(0);
if (next == null) {
return false;
}
current = next;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](search) fix mow support for search function [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56927:
URL: https://github.com/apache/doris/pull/56927#issuecomment-3401710731
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](search) fix mow support for search function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56927:
URL: https://github.com/apache/doris/pull/56927#issuecomment-3400312040
<details>
<summary>TPC-DS: <b>Total hot run time: 187958 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d0baeb1b383f051fb2d943f8a38c7be1e5dec8c6, data reload: false
query1 1073 430 404 404
query2 6563 1684 1681 1681
query3 6755 226 228 226
query4 26266 23555 23235 23235
query5 4962 650 512 512
query6 362 266 267 266
query7 4660 494 308 308
query8 312 262 254 254
query9 8742 2576 2571 2571
query10 520 362 298 298
query11 15443 15145 14972 14972
query12 196 125 113 113
query13 1683 573 450 450
query14 11859 9193 9262 9193
query15 269 194 177 177
query16 7922 756 611 611
query17 1750 853 726 726
query18 2224 462 359 359
query19 416 218 180 180
query20 134 130 125 125
query21 211 140 121 121
query22 4744 4661 4519 4519
query23 34954 33696 33722 33696
query24 8868 2493 2591 2493
query25 639 523 457 457
query26 1218 279 161 161
query27 2767 518 375 375
query28 4459 2246 2182 2182
query29 805 640 554 554
query30 313 248 223 223
query31 984 851 779 779
query32 87 68 72 68
query33 582 379 320 320
query34 792 864 520 520
query35 804 854 747 747
query36 956 1013 973 973
query37 126 111 84 84
query38 3631 3544 3489 3489
query39 1497 1406 1467 1406
query40 215 126 116 116
query41 60 62 58 58
query42 118 114 113 113
query43 489 507 483 483
query44 1340 829 828 828
query45 184 185 178 178
query46 832 988 642 642
query47 1777 1842 1719 1719
query48 413 429 315 315
query49 771 528 417 417
query50 655 730 413 413
query51 3900 4008 3946 3946
query52 112 117 107 107
query53 233 258 195 195
query54 596 596 535 535
query55 90 84 83 83
query56 319 312 312 312
query57 1173 1193 1117 1117
query58 291 284 273 273
query59 2658 2678 2424 2424
query60 350 346 340 340
query61 162 158 157 157
query62 806 750 670 670
query63 239 195 198 195
query64 4423 1163 834 834
query65 4046 3969 3964 3964
query66 1096 446 332 332
query67 15777 15469 15001 15001
query68 8163 937 604 604
query69 464 326 295 295
query70 1330 1288 1361 1288
query71 472 336 306 306
query72 5808 4918 2615 2615
query73 558 578 358 358
query74 9219 9151 8883 8883
query75 4241 3316 2830 2830
query76 4132 1190 757 757
query77 954 417 325 325
query78 9642 9627 8906 8906
query79 4500 831 586 586
query80 747 564 521 521
query81 491 263 230 230
query82 837 165 132 132
query83 285 266 253 253
query84 302 124 98 98
query85 894 481 435 435
query86 415 337 305 305
query87 3785 3723 3662 3662
query88 3240 2255 2244 2244
query89 445 337 301 301
query90 1988 283 226 226
query91 164 162 139 139
query92 83 69 62 62
query93 2477 990 638 638
query94 717 451 336 336
query95 409 327 321 321
query96 483 581 290 290
query97 2962 2985 2897 2897
query98 240 221 213 213
query99 1451 1466 1307 1307
Total cold run time: 285571 ms
Total hot run time: 187958 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](search) fix mow support for search function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56927:
URL: https://github.com/apache/doris/pull/56927#issuecomment-3400324926
<details>
<summary>ClickBench: <b>Total hot run time: 29.98 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d0baeb1b383f051fb2d943f8a38c7be1e5dec8c6, data reload: false
query1 0.06 0.05 0.04
query2 0.10 0.05 0.05
query3 0.26 0.09 0.09
query4 1.61 0.11 0.12
query5 0.27 0.26 0.25
query6 1.18 0.64 0.65
query7 0.04 0.03 0.03
query8 0.06 0.05 0.04
query9 0.63 0.52 0.52
query10 0.58 0.60 0.58
query11 0.17 0.11 0.11
query12 0.14 0.12 0.12
query13 0.63 0.62 0.62
query14 1.03 1.02 1.02
query15 0.88 0.87 0.87
query16 0.40 0.41 0.40
query17 1.11 1.05 1.05
query18 0.22 0.20 0.20
query19 1.92 1.82 1.93
query20 0.02 0.01 0.02
query21 15.42 0.94 0.57
query22 0.75 1.18 0.59
query23 15.04 1.41 0.65
query24 6.84 3.04 0.41
query25 0.30 0.15 0.12
query26 0.59 0.16 0.14
query27 0.06 0.06 0.05
query28 9.38 1.33 0.94
query29 12.54 3.99 3.24
query30 0.29 0.14 0.12
query31 2.83 0.61 0.38
query32 3.26 0.56 0.47
query33 3.11 3.17 3.08
query34 16.18 5.46 4.84
query35 4.92 4.91 4.92
query36 0.68 0.52 0.50
query37 0.11 0.08 0.07
query38 0.07 0.05 0.05
query39 0.04 0.03 0.04
query40 0.19 0.15 0.15
query41 0.10 0.03 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.04
Total cold run time: 104.09 s
Total hot run time: 29.98 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](search) fix mow support for search function [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56927:
URL: https://github.com/apache/doris/pull/56927#issuecomment-3399968328
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](search) fix mow support for search function [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56927:
URL: https://github.com/apache/doris/pull/56927#issuecomment-3400791557
# FE Regression Coverage Report
Increment line coverage ` 100.00% (14/14)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56927_d0baeb1b383f051fb2d943f8a38c7be1e5dec8c6_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56927_d0baeb1b383f051fb2d943f8a38c7be1e5dec8c6_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](search) fix mow support for search function [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56927:
URL: https://github.com/apache/doris/pull/56927#issuecomment-3400426851
# FE UT Coverage Report
Increment line coverage ` 85.71% (12/14)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56927_d0baeb1b383f051fb2d943f8a38c7be1e5dec8c6/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56927_d0baeb1b383f051fb2d943f8a38c7be1e5dec8c6/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](search) fix mow support for search function [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56927:
URL: https://github.com/apache/doris/pull/56927#issuecomment-3401264942
# FE Regression Coverage Report
Increment line coverage ` 100.00% (14/14)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56927_d0baeb1b383f051fb2d943f8a38c7be1e5dec8c6_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56927_d0baeb1b383f051fb2d943f8a38c7be1e5dec8c6_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org