You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/28 10:45:40 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6340: Change dpends on SCHED_[L|H]PWORK to SCHED_WORKQUEUE
xiaoxiang781216 opened a new pull request, #6340:
URL: https://github.com/apache/incubator-nuttx/pull/6340
## Summary
since the code could map the unsupported work to the supported one
and remove select SCHED_WORKQUEUE from Kconfig since SCHED_[L|H]PWORK already do the selection.
## Impact
Should same as before
## Testing
ostest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6340: Change dpends on SCHED_[L|H]PWORK to SCHED_WORKQUEUE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6340:
URL: https://github.com/apache/incubator-nuttx/pull/6340#discussion_r884139983
##########
arch/arm/src/cxd56xx/Kconfig:
##########
@@ -80,7 +80,7 @@ if CXD56_PMIC
config CXD56_PMIC_INT
bool "PMIC interrupt"
default n
- depends on SCHED_LPWORK
Review Comment:
> @xiaoxiang781216 could you please write more about this change and changes in other files `depends on SCHED_HPWORK` -> `depends on SCHED_WORKQUEUE`. I see that both `SCHED_LPWORK` and `SCHED_HPWORK` are defaulted to `n`, so I'm wondering how things are getting working now if for example `CXD56_PMIC_INT` is selected together with `SCHED_WORKQUEUE`, but `SCHED_LPWORK` is `n`.
SCHED_WORKQUEUE can't be selected in defconfig since it doesn't have a prompt string:
https://github.com/apache/incubator-nuttx/blob/master/sched/Kconfig#L1581-L1582
On the other hand, SCHED_WORKQUEUE is selected by SCHED_LPWORK or SCHED_HPWORK automatically:
https://github.com/apache/incubator-nuttx/blob/master/sched/Kconfig#L1601
https://github.com/apache/incubator-nuttx/blob/master/sched/Kconfig#L1667
So, if SCHED_WORKQUEUE is enable, which mean at least one of SCHED_LPWORK and SCHED_HPWORK is enabled too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6340: Change dpends on SCHED_[L|H]PWORK to SCHED_WORKQUEUE
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6340:
URL: https://github.com/apache/incubator-nuttx/pull/6340#discussion_r884149067
##########
boards/arm/c5471/c5471evm/configs/httpd/defconfig:
##########
@@ -35,7 +35,6 @@ CONFIG_RAM_SIZE=285212672
CONFIG_RAM_START=0
CONFIG_RR_INTERVAL=200
CONFIG_SCHED_HPWORK=y
-CONFIG_SCHED_LPWORK=y
Review Comment:
I see. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6340: Change dpends on SCHED_[L|H]PWORK to SCHED_WORKQUEUE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6340:
URL: https://github.com/apache/incubator-nuttx/pull/6340#discussion_r884148626
##########
boards/arm/c5471/c5471evm/configs/httpd/defconfig:
##########
@@ -35,7 +35,6 @@ CONFIG_RAM_SIZE=285212672
CONFIG_RAM_START=0
CONFIG_RR_INTERVAL=200
CONFIG_SCHED_HPWORK=y
-CONFIG_SCHED_LPWORK=y
Review Comment:
CONFIG_SCHED_LPWORK is added by PR https://github.com/apache/incubator-nuttx/pull/6330, because that patch let NET_TCP depend on SCHED_LPWORK. Since this patch change NET_TCP to depend on SCHED_WORKQUEUE, we can revert all related change from #6330.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6340: Change dpends on SCHED_[L|H]PWORK to SCHED_WORKQUEUE
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6340:
URL: https://github.com/apache/incubator-nuttx/pull/6340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6340: Change dpends on SCHED_[L|H]PWORK to SCHED_WORKQUEUE
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6340:
URL: https://github.com/apache/incubator-nuttx/pull/6340#discussion_r884147958
##########
boards/arm/c5471/c5471evm/configs/httpd/defconfig:
##########
@@ -35,7 +35,6 @@ CONFIG_RAM_SIZE=285212672
CONFIG_RAM_START=0
CONFIG_RR_INTERVAL=200
CONFIG_SCHED_HPWORK=y
-CONFIG_SCHED_LPWORK=y
Review Comment:
And why `CONFIG_SCHED_LPWORK=y` is removed from `defconfig` files? I see
```
# if defined(CONFIG_SCHED_LPWORK) && defined(CONFIG_SCHED_HPWORK)
# define LPWORK (HPWORK+1) /* Low priority, kernel-mode work queue */
# else
# define LPWORK HPWORK /* Redirect low-priority references */
# endif
```
so if both `CONFIG_SCHED_HPWORK` and `CONFIG_SCHED_LPWORK` are `y` we are having separate `LPWORK` and `HPWORK` otherwise `LPWORK` is redirected to the `HPWORK`. Does this change mean that all `LPWORK`'s will start run in high priority?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6340: Change dpends on SCHED_[L|H]PWORK to SCHED_WORKQUEUE
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6340:
URL: https://github.com/apache/incubator-nuttx/pull/6340#discussion_r884139326
##########
arch/arm/src/cxd56xx/Kconfig:
##########
@@ -80,7 +80,7 @@ if CXD56_PMIC
config CXD56_PMIC_INT
bool "PMIC interrupt"
default n
- depends on SCHED_LPWORK
Review Comment:
@xiaoxiang781216 could you please write more about this change and changes in other files `depends on SCHED_HPWORK` -> `depends on SCHED_WORKQUEUE`. I see that both `SCHED_LPWORK` and `SCHED_HPWORK` are defaulted to `n`, so I'm wondering how things are getting working now if for example `CXD56_PMIC_INT` is selected together with `SCHED_WORKQUEUE`, but `SCHED_LPWORK` is `n`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org