You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "breautek (via GitHub)" <gi...@apache.org> on 2023/03/15 14:21:00 UTC
[GitHub] [cordova-android] breautek opened a new pull request, #1571: feat!: Bump min SDK to 24
breautek opened a new pull request, #1571:
URL: https://github.com/apache/cordova-android/pull/1571
Rationale:
API 22 & API 24 both account for an insignificant part of the market share. While API 24 - API 26 has similar market share, we felt that bumping to API 26 from API 22 is too large of a jump.
Legacy devices may be completely out of support by Google and may not be able to receive the latest webview version. As of writing, Chromium's latest tag shows they are using a Min SDK version of 24. (Ref: https://chromium.googlesource.com/chromium/src/+/refs/tags/113.0.5653.1/build/config/android/config.gni#46)
Based on AOSP emulators, API 24 (Android 7.0) will ship with Chrome 52 webview, which has good support for ECMAscript 2015 (ES6) (Ref: https://caniuse.com/?search=es6)
While in most cases, app users will likely have a modern webview vesion installed, this means you can be confident that the app user will have a chrome webview version with good ES6 support, even if they happen to be running on a factory versioned device.
See the mailing thread for the full discussion:
https://lists.apache.org/thread/zcgof080hdzzo2j96mjz0qpj0gotmn57
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on pull request #1571: feat!: Bump min SDK to 24
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #1571:
URL: https://github.com/apache/cordova-android/pull/1571#issuecomment-1470263762
> > API 22 & API 24
>
> nit: I think you meant "API 22 & API 23", and think it would be ideal if we could get this fixed in the commit message as well.
Good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1571: feat!: Bump min SDK to 24
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1571:
URL: https://github.com/apache/cordova-android/pull/1571#issuecomment-1470289154
## [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1571?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1571](https://codecov.io/gh/apache/cordova-android/pull/1571?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6ad35a0) into [master](https://codecov.io/gh/apache/cordova-android/commit/04723eb8f3e89b5edf4dfd2ec515e92a18b94e43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04723eb) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1571 +/- ##
=======================================
Coverage 72.13% 72.13%
=======================================
Files 21 21
Lines 1751 1751
=======================================
Hits 1263 1263
Misses 488 488
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek merged pull request #1571: feat!: Bump min SDK to 24
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek merged PR #1571:
URL: https://github.com/apache/cordova-android/pull/1571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] brodybits commented on pull request #1571: feat!: Bump min SDK to 24
Posted by "brodybits (via GitHub)" <gi...@apache.org>.
brodybits commented on PR #1571:
URL: https://github.com/apache/cordova-android/pull/1571#issuecomment-1470208112
> API 22 & API 24
nit: I think you meant "API 22 & API 23", and think it would be ideal if we could get this fixed in the commit message as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org