You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/08/07 15:00:49 UTC
Review Request 24450: Add ability to an agent to cancel queued/running tasks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24450/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-6768
https://issues.apache.org/jira/browse/AMBARI-6768
Repository: ambari
Description
-------
ira scope:
Agent should accept a list of CANCEL_COMMANDs inside heartbeat response (cancelCommands). CANCEL_COMMAND looks like:
{
target_task_id: "4-3"
reason: "Aborted by a user via API" // Text that has been provided at abort_reason field via API
}
For cancelled tasks (that were in pending or in_progress state), a command report should be generated and sent to a server.
As of now, only cancelling ordinary commands should be supported.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py 58d3e75
ambari-agent/src/main/python/ambari_agent/Controller.py 36ed94c
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 4331678
ambari-agent/src/main/python/ambari_agent/PythonExecutor.py c4f1234
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 04c12b2
ambari-agent/src/test/python/ambari_agent/TestController.py 6c1dcd0
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py e8668f6
ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py c33b97d
Diff: https://reviews.apache.org/r/24450/diff/
Testing
-------
Manual end-to-end + unit tests
Thanks,
Dmytro Sen
Re: Review Request 24450: Add ability to an agent to cancel queued/running
tasks
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24450/#review49889
-----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/Controller.py
<https://reviews.apache.org/r/24450/#comment87305>
Log message may be misleading
- Dmitro Lisnichenko
On Aug. 7, 2014, 1 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24450/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2014, 1 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-6768
> https://issues.apache.org/jira/browse/AMBARI-6768
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ira scope:
> Agent should accept a list of CANCEL_COMMANDs inside heartbeat response (cancelCommands). CANCEL_COMMAND looks like:
> {
> target_task_id: "4-3"
> reason: "Aborted by a user via API" // Text that has been provided at abort_reason field via API
> }
> For cancelled tasks (that were in pending or in_progress state), a command report should be generated and sent to a server.
> As of now, only cancelling ordinary commands should be supported.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 58d3e75
> ambari-agent/src/main/python/ambari_agent/Controller.py 36ed94c
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 4331678
> ambari-agent/src/main/python/ambari_agent/PythonExecutor.py c4f1234
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 04c12b2
> ambari-agent/src/test/python/ambari_agent/TestController.py 6c1dcd0
> ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py e8668f6
> ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py c33b97d
>
> Diff: https://reviews.apache.org/r/24450/diff/
>
>
> Testing
> -------
>
> Manual end-to-end + unit tests
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 24450: Add ability to an agent to cancel queued/running
tasks
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24450/#review49892
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Aug. 7, 2014, 1:38 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24450/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2014, 1:38 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-6768
> https://issues.apache.org/jira/browse/AMBARI-6768
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ira scope:
> Agent should accept a list of CANCEL_COMMANDs inside heartbeat response (cancelCommands). CANCEL_COMMAND looks like:
> {
> target_task_id: "4-3"
> reason: "Aborted by a user via API" // Text that has been provided at abort_reason field via API
> }
> For cancelled tasks (that were in pending or in_progress state), a command report should be generated and sent to a server.
> As of now, only cancelling ordinary commands should be supported.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 58d3e75
> ambari-agent/src/main/python/ambari_agent/Controller.py 36ed94c
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 4331678
> ambari-agent/src/main/python/ambari_agent/PythonExecutor.py c4f1234
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 04c12b2
> ambari-agent/src/test/python/ambari_agent/TestController.py 6c1dcd0
> ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py e8668f6
> ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py c33b97d
>
> Diff: https://reviews.apache.org/r/24450/diff/
>
>
> Testing
> -------
>
> Manual end-to-end + unit tests
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 24450: Add ability to an agent to cancel queued/running
tasks
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24450/
-----------------------------------------------------------
(Updated Aug. 7, 2014, 2:14 p.m.)
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-6768
https://issues.apache.org/jira/browse/AMBARI-6768
Repository: ambari
Description
-------
ira scope:
Agent should accept a list of CANCEL_COMMANDs inside heartbeat response (cancelCommands). CANCEL_COMMAND looks like:
{
target_task_id: "4-3"
reason: "Aborted by a user via API" // Text that has been provided at abort_reason field via API
}
For cancelled tasks (that were in pending or in_progress state), a command report should be generated and sent to a server.
As of now, only cancelling ordinary commands should be supported.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py 58d3e75
ambari-agent/src/main/python/ambari_agent/Controller.py 36ed94c
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 4331678
ambari-agent/src/main/python/ambari_agent/PythonExecutor.py c4f1234
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 04c12b2
ambari-agent/src/test/python/ambari_agent/TestController.py 6c1dcd0
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py e8668f6
ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py c33b97d
Diff: https://reviews.apache.org/r/24450/diff/
Testing (updated)
-------
Manual end-to-end + unit tests
Tests run: 1883, Failures: 0, Errors: 0, Skipped: 24
Thanks,
Dmytro Sen
Re: Review Request 24450: Add ability to an agent to cancel queued/running
tasks
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24450/
-----------------------------------------------------------
(Updated Aug. 7, 2014, 1:38 p.m.)
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-6768
https://issues.apache.org/jira/browse/AMBARI-6768
Repository: ambari
Description
-------
ira scope:
Agent should accept a list of CANCEL_COMMANDs inside heartbeat response (cancelCommands). CANCEL_COMMAND looks like:
{
target_task_id: "4-3"
reason: "Aborted by a user via API" // Text that has been provided at abort_reason field via API
}
For cancelled tasks (that were in pending or in_progress state), a command report should be generated and sent to a server.
As of now, only cancelling ordinary commands should be supported.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py 58d3e75
ambari-agent/src/main/python/ambari_agent/Controller.py 36ed94c
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 4331678
ambari-agent/src/main/python/ambari_agent/PythonExecutor.py c4f1234
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 04c12b2
ambari-agent/src/test/python/ambari_agent/TestController.py 6c1dcd0
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py e8668f6
ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py c33b97d
Diff: https://reviews.apache.org/r/24450/diff/
Testing
-------
Manual end-to-end + unit tests
Thanks,
Dmytro Sen