You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by cs...@apache.org on 2016/07/13 15:28:31 UTC

karaf-decanter git commit: Small refactoring

Repository: karaf-decanter
Updated Branches:
  refs/heads/master 5407124af -> 6225e9211


Small refactoring


Project: http://git-wip-us.apache.org/repos/asf/karaf-decanter/repo
Commit: http://git-wip-us.apache.org/repos/asf/karaf-decanter/commit/6225e921
Tree: http://git-wip-us.apache.org/repos/asf/karaf-decanter/tree/6225e921
Diff: http://git-wip-us.apache.org/repos/asf/karaf-decanter/diff/6225e921

Branch: refs/heads/master
Commit: 6225e9211300716e8201dcb119edd587f9a58af5
Parents: 5407124
Author: Christian Schneider <ch...@die-schneider.net>
Authored: Wed Jul 13 17:28:23 2016 +0200
Committer: Christian Schneider <ch...@die-schneider.net>
Committed: Wed Jul 13 17:28:23 2016 +0200

----------------------------------------------------------------------
 .../decanter/appender/jms/JmsAppender.java      | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/karaf-decanter/blob/6225e921/appender/jms/src/main/java/org/apache/karaf/decanter/appender/jms/JmsAppender.java
----------------------------------------------------------------------
diff --git a/appender/jms/src/main/java/org/apache/karaf/decanter/appender/jms/JmsAppender.java b/appender/jms/src/main/java/org/apache/karaf/decanter/appender/jms/JmsAppender.java
index f72bfab..90289fb 100644
--- a/appender/jms/src/main/java/org/apache/karaf/decanter/appender/jms/JmsAppender.java
+++ b/appender/jms/src/main/java/org/apache/karaf/decanter/appender/jms/JmsAppender.java
@@ -106,23 +106,15 @@ public class JmsAppender implements EventHandler {
     }
 
     private Destination createDestination(Session session) throws JMSException {
-        Destination destination;
-        if (destinationType.equalsIgnoreCase("topic")) {
-            destination = session.createTopic(destinationName);
-        } else {
-            destination = session.createQueue(destinationName);
-        }
-        return destination;
+        return (destinationType.equalsIgnoreCase("topic"))
+            ? session.createTopic(destinationName)
+            : session.createQueue(destinationName);
     }
 
     private Connection createConnection() throws JMSException {
-        Connection connection;
-        if (username != null) {
-            connection = connectionFactory.createConnection(username, password);
-        } else {
-            connection = connectionFactory.createConnection();
-        }
-        return connection;
+        return (username != null) 
+            ? connectionFactory.createConnection(username, password)
+            : connectionFactory.createConnection();
     }
 
     public void safeClose(Session sess) {