You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/09/22 17:00:53 UTC
[GitHub] [maven-parent] tisonkun opened a new pull request, #135: Support develop with JDK 21
tisonkun opened a new pull request, #135:
URL: https://github.com/apache/maven-parent/pull/135
See also https://github.com/diffplug/spotless/issues/1819#issuecomment-1726986315.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPOM-429] Support develop with JDK 21 (palantirJavaFormat update) [maven-parent]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #135:
URL: https://github.com/apache/maven-parent/pull/135#issuecomment-2703319240
Resolve #303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPOM-429] Support develop with JDK 21 (palantirJavaFormat update) [maven-parent]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #135:
URL: https://github.com/apache/maven-parent/pull/135#issuecomment-1742932559
May I ask the release plan including this patch? I create this patch due to my project want to upgrade to be compatible with JDK 21 dev :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] slawekjaranowski commented on a diff in pull request #135: Support develop with JDK 21
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #135:
URL: https://github.com/apache/maven-parent/pull/135#discussion_r1334946892
##########
pom.xml:
##########
@@ -1168,12 +1168,14 @@ under the License.
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
- <version>2.37.0</version>
+ <version>2.39.0</version>
Review Comment:
done in #134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPOM-429] Support develop with JDK 21 (palantirJavaFormat update) [maven-parent]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #135:
URL: https://github.com/apache/maven-parent/pull/135#issuecomment-1742988250
Oops. It's not hawkeye where I can pin dependencies by myself and doesn't inherit the MPOM...
I forget where I come from now 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPOM-429] Support develop with JDK 21 (palantirJavaFormat update) [maven-parent]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #135:
URL: https://github.com/apache/maven-parent/pull/135#issuecomment-1742845840
Thanks for your review and suggestion!
We can still use this patch now as https://github.com/diffplug/spotless/pull/1822 is unresolved yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] slawekjaranowski commented on pull request #135: Support develop with JDK 21
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #135:
URL: https://github.com/apache/maven-parent/pull/135#issuecomment-1732261816
I would like to wait for fix in spotless: https://github.com/diffplug/spotless/pull/1822
If no before next release of parents we can consider it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPOM-429] Support develop with JDK 21 (palantirJavaFormat update) [maven-parent]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #135:
URL: https://github.com/apache/maven-parent/pull/135#issuecomment-1742870076
Yes, I think patching spotless may take some more time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPOM-429] Support develop with JDK 21 (palantirJavaFormat update) [maven-parent]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #135:
URL: https://github.com/apache/maven-parent/pull/135#issuecomment-1742943586
@tisonkun - Just out of curiosity - how this project impact on your project?
It is only used by Apache Maven projects as our parents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] slawekjaranowski commented on a diff in pull request #135: Support develop with JDK 21
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #135:
URL: https://github.com/apache/maven-parent/pull/135#discussion_r1334947246
##########
pom.xml:
##########
@@ -1168,12 +1168,14 @@ under the License.
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
- <version>2.37.0</version>
+ <version>2.39.0</version>
<configuration>
<java>
<!-- orders of used formatters are important MPOM-376 -->
<!-- eg. palantir override importOrder, so should be first -->
- <palantirJavaFormat />
+ <palantirJavaFormat>
+ <version>2.36.0</version>
+ </palantirJavaFormat>
Review Comment:
please add link to spotless issue https://github.com/diffplug/spotless/issues/1774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPOM-429] Support develop with JDK 21 (palantirJavaFormat update) [maven-parent]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz merged PR #135:
URL: https://github.com/apache/maven-parent/pull/135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MPOM-429] Support develop with JDK 21 (palantirJavaFormat update) [maven-parent]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #135:
URL: https://github.com/apache/maven-parent/pull/135#issuecomment-1746462514
@slawekjaranowski I encountered it again and remembered. I met this issue from Apache Curator who inherited this pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org