You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by maxlip <gi...@git.apache.org> on 2017/11/13 19:05:19 UTC
[GitHub] libcloud pull request #1144: LIBCLOUD-960: Expand GCE Firewall options cover...
GitHub user maxlip opened a pull request:
https://github.com/apache/libcloud/pull/1144
LIBCLOUD-960: Expand GCE Firewall options coverage
## Expand GCE Firewall options coverage
### Description
Expanding coverage for full range of GCP firewall rule options currently in GA:
- Ingress or Egress direction
- Allow or Deny action
- Set Description and Priority values
- Define source and/or targets by service account
I've preserved the existing defaults.
Issue Link: https://issues.apache.org/jira/browse/LIBCLOUD-960
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [x] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maxlip/libcloud LIBCLOUD-960_GCEFW-4Way-SvcAcct
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/1144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1144
----
commit cdf4a73045c0226757930a134d44afa024fba757
Author: Max <ma...@gmail.com>
Date: 2017-11-13T18:54:34Z
LIBCLOUD-960: Expand GCE Firewall options coverage
----
---
[GitHub] libcloud pull request #1144: LIBCLOUD-960: Expand GCE Firewall options cover...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/libcloud/pull/1144
---