[GitHub] [incubator-superset] DiggidyDave opened a new pull request #7997: Allow preconfigured event logger inst

[GitBox <gi...@apache.org>]

DiggidyDave opened a new pull request #7997: Allow preconfigured event logger inst
URL: https://github.com/apache/incubator-superset/pull/7997
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [X] Refactor
   - [X] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Deprecate EVENT_LOGGER assignment of class type in favor of instance. Deprecation is handled gracefully and only outputs a WARNING log message at config load time.  We have a need to configure an impl of AbstractEventLogger which is instantiated/pre-configured with some proprietary dependencies.
   
   This change is a small refactor on top of the nice change #7705 @dpgaspar made a few weeks ago.
   
   ### TEST PLAN
   Unit tests added, and tested manually.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [X] Has associated issue: 7705
   
   ### REVIEWERS
   @dpgaspar @john-bodley @graceguo-supercat @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org