[activemq-artemis] branch main updated: ARTEMIS-3473 Some tests were leaving a directory named null for journal files under tests/integration-tests

[cl...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

clebertsuconic pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git


The following commit(s) were added to refs/heads/main by this push:
     new 7792d8f7 ARTEMIS-3473 Some tests were leaving a directory named null for journal files under tests/integration-tests
7792d8f7 is described below

commit 7792d8f7b34605ee1b491307b41e336ffe632442
Author: Clebert Suconic <cl...@apache.org>
AuthorDate: Fri Sep 10 17:43:06 2021 -0400

    ARTEMIS-3473 Some tests were leaving a directory named null for journal files under tests/integration-tests
---
 .../org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java  | 8 ++++++--
 .../artemis/tests/integration/mqtt/imported/MQTTTestSupport.java  | 1 +
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java b/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
index a3c1971..330b55a 100644
--- a/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
+++ b/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
@@ -196,7 +196,7 @@ public abstract class ActiveMQTestBase extends Assert {
     *  your data even under ./target.
     *  Do not try to disable this rule! Fix your test! */
    @Rule
-   public NoFilesBehind noFilesBehind = new NoFilesBehind("data");
+   public NoFilesBehind noFilesBehind = new NoFilesBehind("data", "null");
 
    /** This will cleanup any system property changed inside tests */
    @Rule
@@ -407,9 +407,13 @@ public abstract class ActiveMQTestBase extends Assert {
    }
 
    @Before
+   public void setupTestDir() {
+      testDir = temporaryFolder.getRoot().getAbsolutePath();
+   }
+
+   @Before
    public void setUp() throws Exception {
       sendMsgCount = 0;
-      testDir = temporaryFolder.getRoot().getAbsolutePath();
       clearDataRecreateServerDirs();
       OperationContextImpl.clearContext();
 
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTTestSupport.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTTestSupport.java
index 8972dae..8a87c98 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTTestSupport.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTTestSupport.java
@@ -130,6 +130,7 @@ public class MQTTTestSupport extends ActiveMQTestBase {
    @Override
    @Before
    public void setUp() throws Exception {
+      super.setUp();
       String basedir = basedir().getPath();
       System.setProperty("javax.net.ssl.trustStore", basedir + "/src/test/resources/client.keystore");
       System.setProperty("javax.net.ssl.trustStorePassword", "password");