[GitHub] [pulsar] eolivelli commented on pull request #11794: jwks feature for oAuth flow

[GitBox <gi...@apache.org>]

eolivelli commented on pull request #11794:
URL: https://github.com/apache/pulsar/pull/11794#issuecomment-910281308


   > I don't think I agree with making this its own module. If we did, I'd wonder why it wasn't in its own repository, or some kind of Pulsar Contrib repository. I don't have a fully formed opinion, though. I can provider more feedback tomorrow.
   
   @michaeljmarshall we have other components that are in the repo and that are not released in the "lib" directory, for instance the offloaders.
   
   If this is meant to be a core feature, available out of the box, then it is fine to put it in "lib", otherwise it is better to create a separate module and let users add it to their system if they want.
   
   My point here is about not adding "optional" modules to the core distribution.
   
   Probably having some high level description of this feature, would help in understanding why this feature is so useful and why we should add it to Pulsar core.
   Maybe it is just me, that I do not know **JWKS** and so I do not see the value in adding it to the core distribution, but I see more third party dependencies added to the core distribution.
   
   Please note that I am not against this feature, I am sure it is useful. I am concerned only about the distribution of this code and the dependencies to the end users
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org