You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by "bdoyle0182 (via GitHub)" <gi...@apache.org> on 2023/05/02 23:28:28 UTC
[GitHub] [openwhisk] bdoyle0182 opened a new pull request, #5405: update scheduler not processing metric to counter
bdoyle0182 opened a new pull request, #5405:
URL: https://github.com/apache/openwhisk/pull/5405
## Description
This metric unfortunately does not work as a gauge. A gauge will report until there is a change in the value. I previously made a change so that the value would change back to 0 when a new activation is processed. However this does not account for 1. when the queue is stopped before setting the value back to 0 and 2. a queue is moved to a new host before the value is set back to 0 so the value for the action is still emitting 1 until a restart incorrectly reporting.
## Related issue and scope
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [X] Scheduler
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
- [X] Bug fix (generally a non-breaking change which closes an issue).
- [ ] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
- [X] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [X] I reviewed the [style guides](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md#coding-standards) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] bdoyle0182 merged pull request #5405: update scheduler not processing metric to counter
Posted by "bdoyle0182 (via GitHub)" <gi...@apache.org>.
bdoyle0182 merged PR #5405:
URL: https://github.com/apache/openwhisk/pull/5405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] codecov-commenter commented on pull request #5405: update scheduler not processing metric to counter
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5405:
URL: https://github.com/apache/openwhisk/pull/5405#issuecomment-1532289413
## [Codecov](https://app.codecov.io/gh/apache/openwhisk/pull/5405?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#5405](https://app.codecov.io/gh/apache/openwhisk/pull/5405?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ccfac09) into [master](https://app.codecov.io/gh/apache/openwhisk/commit/d84e4eefb764b36b63867967b1882d1226481f61?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d84e4ee) will **decrease** coverage by `72.17%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head ccfac09 differs from pull request most recent head 43ba7da. Consider uploading reports for the commit 43ba7da to get more accurate results
```diff
@@ Coverage Diff @@
## master #5405 +/- ##
==========================================
- Coverage 76.69% 4.52% -72.17%
==========================================
Files 240 240
Lines 14596 14592 -4
Branches 671 666 -5
==========================================
- Hits 11194 660 -10534
- Misses 3402 13932 +10530
```
| [Impacted Files](https://app.codecov.io/gh/apache/openwhisk/pull/5405?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/openwhisk/core/scheduler/queue/MemoryQueue.scala](https://app.codecov.io/gh/apache/openwhisk/pull/5405?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zY2hlZHVsZXIvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9vcGVud2hpc2svY29yZS9zY2hlZHVsZXIvcXVldWUvTWVtb3J5UXVldWUuc2NhbGE=) | `0.00% <0.00%> (-80.44%)` | :arrow_down: |
... and [204 files with indirect coverage changes](https://app.codecov.io/gh/apache/openwhisk/pull/5405/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org