[GitHub] [echarts] plainheart commented on issue #14594: Setting the borderwidth property in a line chart does not work

[GitBox <gi...@apache.org>]

plainheart commented on issue #14594:
URL: https://github.com/apache/echarts/issues/14594#issuecomment-813276949


   Thanks for your feedback! It seems to be brought by [51c675d](https://github.com/apache/echarts/commit/51c675d11a8ba94d3f47ed170ed5e3b8c1ee5d2e#diff-70d476daeebde08d3c11234fd7b968016f4f4a4edba807cdd76688807d6c061e). If the symbol is empty, the stroke color and line width will be overridden.
   
   Personally, I think we should make the `borderColor` and `borderWidth` work even though it's empty.
   
   ```ts
   symbolStyle.stroke || (symbolStyle.stroke = color);
   // ...
   symbolStyle.lineWidth == null && (symbolStyle.lineWidth = 2);
   ```
   
   That is, if the user has specified borderWidth and borderColor, don't override them whatever it is empty brush.
   
   @pissang I may not understand completely what this change was for, please let us know if the current behavior is expected.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org