You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by le...@apache.org on 2019/07/31 16:44:53 UTC
[incubator-druid] branch master updated: Add SuppressWarnings
SS_SHOULD_BE_STATIC (#8138)
This is an automated email from the ASF dual-hosted git repository.
leventov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new faf5110 Add SuppressWarnings SS_SHOULD_BE_STATIC (#8138)
faf5110 is described below
commit faf51107d590eb6b947fc6f0f3164f5866b671b2
Author: Fokko Driesprong <fo...@apache.org>
AuthorDate: Wed Jul 31 18:44:42 2019 +0200
Add SuppressWarnings SS_SHOULD_BE_STATIC (#8138)
* Spotbugs: SS_SHOULD_BE_STATIC (#8073)
* Add SuppressWarnings SS_SHOULD_BE_STATIC
Fixes #8073
* Fix the voilation
* Make them non-final
* Remove @Nonnull
---
codestyle/spotbugs-exclude.xml | 1 -
.../apache/druid/indexing/worker/config/WorkerConfig.java | 15 ++++++---------
.../druid/server/security/AnonymousAuthenticator.java | 2 +-
3 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/codestyle/spotbugs-exclude.xml b/codestyle/spotbugs-exclude.xml
index fe8a6de..3ee2330 100644
--- a/codestyle/spotbugs-exclude.xml
+++ b/codestyle/spotbugs-exclude.xml
@@ -83,7 +83,6 @@
<Bug pattern="SF_SWITCH_FALLTHROUGH"/>
<Bug pattern="SF_SWITCH_NO_DEFAULT"/>
<Bug pattern="SR_NOT_CHECKED"/>
- <Bug pattern="SS_SHOULD_BE_STATIC"/>
<Bug pattern="SWL_SLEEP_WITH_LOCK_HELD"/>
<Bug pattern="UL_UNRELEASED_LOCK_EXCEPTION_PATH"/>
<Bug pattern="URF_UNREAD_FIELD"/>
diff --git a/indexing-service/src/main/java/org/apache/druid/indexing/worker/config/WorkerConfig.java b/indexing-service/src/main/java/org/apache/druid/indexing/worker/config/WorkerConfig.java
index 65d09e7..4bfa6ee 100644
--- a/indexing-service/src/main/java/org/apache/druid/indexing/worker/config/WorkerConfig.java
+++ b/indexing-service/src/main/java/org/apache/druid/indexing/worker/config/WorkerConfig.java
@@ -25,32 +25,29 @@ import org.apache.druid.utils.JvmUtils;
import org.joda.time.Period;
import javax.validation.constraints.Min;
-import javax.validation.constraints.NotNull;
/**
*/
public class WorkerConfig
{
@JsonProperty
- @NotNull
- private final String ip = DruidNode.getDefaultHost();
+ private String ip = DruidNode.getDefaultHost();
@JsonProperty
- @NotNull
- private final String version = "0";
+ private String version = "0";
@JsonProperty
@Min(1)
- private final int capacity = Math.max(1, JvmUtils.getRuntimeInfo().getAvailableProcessors() - 1);
+ private int capacity = Math.max(1, JvmUtils.getRuntimeInfo().getAvailableProcessors() - 1);
@JsonProperty
- private final long intermediaryPartitionDiscoveryPeriodSec = 60L;
+ private long intermediaryPartitionDiscoveryPeriodSec = 60L;
@JsonProperty
- private final long intermediaryPartitionCleanupPeriodSec = 300L;
+ private long intermediaryPartitionCleanupPeriodSec = 300L;
@JsonProperty
- private final Period intermediaryPartitionTimeout = new Period("P1D");
+ private Period intermediaryPartitionTimeout = new Period("P1D");
public String getIp()
{
diff --git a/server/src/main/java/org/apache/druid/server/security/AnonymousAuthenticator.java b/server/src/main/java/org/apache/druid/server/security/AnonymousAuthenticator.java
index 7cfe76c..a110189 100644
--- a/server/src/main/java/org/apache/druid/server/security/AnonymousAuthenticator.java
+++ b/server/src/main/java/org/apache/druid/server/security/AnonymousAuthenticator.java
@@ -40,8 +40,8 @@ import java.util.Map;
@JsonTypeName("anonymous")
public class AnonymousAuthenticator implements Authenticator
{
+ private static final String DEFAULT_IDENTITY = "defaultUser";
private final AuthenticationResult anonymousResult;
- private final String DEFAULT_IDENTITY = "defaultUser";
@JsonCreator
public AnonymousAuthenticator(
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org