You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Norbert Luksa (Code Review)" <ge...@cloudera.org> on 2019/11/20 10:19:59 UTC
[Impala-ASF-CR] IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
Norbert Luksa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14715
Change subject: IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
......................................................................
IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
When mt_dop > 0, the summary is reporting the number of fragment
instances, instead of the number of hosts as the header would
imply.
This commit fixes the issue so the number of hosts will be shown
under the #Hosts column. The commit also adds an #Instances
column where the number of instances are shown (current behaviour).
Tests:
* Changed profile tests with mt_dop > 0.
* Updated benchmark tests and shell tests accordingly.
Change-Id: I3bdf9a06d9bd842b2397cd16c28294b6bec7af69
---
M be/src/runtime/coordinator.cc
M be/src/util/summary-util.cc
M common/thrift/ExecStats.thrift
M shell/impala_client.py
M shell/impala_shell.py
M testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test
M tests/benchmark/report_benchmark_results.py
M tests/shell/test_shell_commandline.py
8 files changed, 65 insertions(+), 41 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/14715/3
--
To view, visit http://gerrit.cloudera.org:8080/14715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3bdf9a06d9bd842b2397cd16c28294b6bec7af69
Gerrit-Change-Number: 14715
Gerrit-PatchSet: 3
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14715 )
Change subject: IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
......................................................................
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/14715/3/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:
http://gerrit.cloudera.org:8080/#/c/14715/3/be/src/runtime/coordinator.cc@237
PS3, Line 237: // counting the number of hosts and instances
nit: Might want to fix capitalization and punctuation (see comments below), e.g. "Count the number of hosts and instances."
http://gerrit.cloudera.org:8080/#/c/14715/3/be/src/runtime/coordinator.cc@238
PS3, Line 238: const std::vector<FInstanceExecParams>& instance_params =
nit: remove std::
http://gerrit.cloudera.org:8080/#/c/14715/3/be/src/runtime/coordinator.cc@241
PS3, Line 241:
nit: remove space (follow surrounding code, e.g. line 228 and 229)
http://gerrit.cloudera.org:8080/#/c/14715/3/be/src/runtime/coordinator.cc@242
PS3, Line 242: host_set.insert(instance.host);
Do we need to take a copy here? How about "const FInstanceExecParams& instance"?
http://gerrit.cloudera.org:8080/#/c/14715/3/shell/impala_shell.py
File shell/impala_shell.py:
http://gerrit.cloudera.org:8080/#/c/14715/3/shell/impala_shell.py@1080
PS3, Line 1080: return self.construct_table_with_header(["Operator", "#Hosts", "#Instances",
how about #Inst to keep things concise (Please go with the consensus on the email thread on dev@)
--
To view, visit http://gerrit.cloudera.org:8080/14715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bdf9a06d9bd842b2397cd16c28294b6bec7af69
Gerrit-Change-Number: 14715
Gerrit-PatchSet: 3
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 19:53:23 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14715 )
Change subject: IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bdf9a06d9bd842b2397cd16c28294b6bec7af69
Gerrit-Change-Number: 14715
Gerrit-PatchSet: 5
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Nov 2019 07:28:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
Posted by "Norbert Luksa (Code Review)" <ge...@cloudera.org>.
Norbert Luksa has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14715 )
Change subject: IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
......................................................................
IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
When mt_dop > 0, the summary is reporting the number of fragment
instances, instead of the number of hosts as the header would
imply.
This commit fixes the issue so the number of hosts will be shown
under the #Hosts column. The commit also adds an #Inst column
where the number of instances are shown (current behaviour).
Tests:
* Changed profile tests with mt_dop > 0.
* Updated benchmark tests and shell tests accordingly.
Change-Id: I3bdf9a06d9bd842b2397cd16c28294b6bec7af69
---
M be/src/runtime/coordinator.cc
M be/src/util/summary-util.cc
M common/thrift/ExecStats.thrift
M shell/impala_client.py
M shell/impala_shell.py
M testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test
M tests/benchmark/report_benchmark_results.py
M tests/shell/test_shell_commandline.py
8 files changed, 65 insertions(+), 41 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/14715/4
--
To view, visit http://gerrit.cloudera.org:8080/14715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3bdf9a06d9bd842b2397cd16c28294b6bec7af69
Gerrit-Change-Number: 14715
Gerrit-PatchSet: 4
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14715 )
Change subject: IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5082/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bdf9a06d9bd842b2397cd16c28294b6bec7af69
Gerrit-Change-Number: 14715
Gerrit-PatchSet: 3
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 11:04:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
Posted by "Norbert Luksa (Code Review)" <ge...@cloudera.org>.
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14715 )
Change subject: IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
......................................................................
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/14715/3/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:
http://gerrit.cloudera.org:8080/#/c/14715/3/be/src/runtime/coordinator.cc@237
PS3, Line 237: // counting the number of hosts and instances
> nit: Might want to fix capitalization and punctuation (see comments below),
Done
http://gerrit.cloudera.org:8080/#/c/14715/3/be/src/runtime/coordinator.cc@238
PS3, Line 238: const std::vector<FInstanceExecParams>& instance_params =
> nit: remove std::
Done
http://gerrit.cloudera.org:8080/#/c/14715/3/be/src/runtime/coordinator.cc@241
PS3, Line 241:
> nit: remove space (follow surrounding code, e.g. line 228 and 229)
Done
http://gerrit.cloudera.org:8080/#/c/14715/3/be/src/runtime/coordinator.cc@242
PS3, Line 242: host_set.insert(instance.host);
> Do we need to take a copy here? How about "const FInstanceExecParams& insta
Done
http://gerrit.cloudera.org:8080/#/c/14715/3/shell/impala_shell.py
File shell/impala_shell.py:
http://gerrit.cloudera.org:8080/#/c/14715/3/shell/impala_shell.py@1080
PS3, Line 1080: return self.construct_table_with_header(["Operator", "#Hosts", "#Instances",
> how about #Inst to keep things concise (Please go with the consensus on the
Changed it to #Inst for now, will wait for more answers on dev@.
--
To view, visit http://gerrit.cloudera.org:8080/14715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bdf9a06d9bd842b2397cd16c28294b6bec7af69
Gerrit-Change-Number: 14715
Gerrit-PatchSet: 3
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 08:51:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14715 )
Change subject: IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
......................................................................
IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
When mt_dop > 0, the summary is reporting the number of fragment
instances, instead of the number of hosts as the header would
imply.
This commit fixes the issue so the number of hosts will be shown
under the #Hosts column. The commit also adds an #Inst column
where the number of instances are shown (current behaviour).
Tests:
* Changed profile tests with mt_dop > 0.
* Updated benchmark tests and shell tests accordingly.
Change-Id: I3bdf9a06d9bd842b2397cd16c28294b6bec7af69
Reviewed-on: http://gerrit.cloudera.org:8080/14715
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/coordinator.cc
M be/src/util/summary-util.cc
M common/thrift/ExecStats.thrift
M shell/impala_client.py
M shell/impala_shell.py
M testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test
M tests/benchmark/report_benchmark_results.py
M tests/shell/test_shell_commandline.py
8 files changed, 65 insertions(+), 41 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3bdf9a06d9bd842b2397cd16c28294b6bec7af69
Gerrit-Change-Number: 14715
Gerrit-PatchSet: 6
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14715 )
Change subject: IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
......................................................................
Patch Set 4: Code-Review+2
LGTM, please give the dev@ discussion another day or so before submitting.
--
To view, visit http://gerrit.cloudera.org:8080/14715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bdf9a06d9bd842b2397cd16c28294b6bec7af69
Gerrit-Change-Number: 14715
Gerrit-PatchSet: 4
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 22:37:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14715 )
Change subject: IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5097/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bdf9a06d9bd842b2397cd16c28294b6bec7af69
Gerrit-Change-Number: 14715
Gerrit-PatchSet: 4
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 10:02:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14715 )
Change subject: IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5296/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bdf9a06d9bd842b2397cd16c28294b6bec7af69
Gerrit-Change-Number: 14715
Gerrit-PatchSet: 5
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Nov 2019 02:11:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14715 )
Change subject: IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bdf9a06d9bd842b2397cd16c28294b6bec7af69
Gerrit-Change-Number: 14715
Gerrit-PatchSet: 3
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 18:09:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14715 )
Change subject: IMPALA-4618: Fixing #Hosts and adding #Instances in exec summary
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bdf9a06d9bd842b2397cd16c28294b6bec7af69
Gerrit-Change-Number: 14715
Gerrit-PatchSet: 5
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Nov 2019 02:11:38 +0000
Gerrit-HasComments: No