You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/07/15 06:07:52 UTC
[GitHub] [ignite] RealZheka opened a new pull request #8041: IGNITE-13259 Removed default cache from REST APIs
RealZheka opened a new pull request #8041:
URL: https://github.com/apache/ignite/pull/8041
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] RealZheka commented on a change in pull request #8041: IGNITE-13259 Removed default cache from REST APIs
Posted by GitBox <gi...@apache.org>.
RealZheka commented on a change in pull request #8041:
URL: https://github.com/apache/ignite/pull/8041#discussion_r458461812
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/GridRestCommandHandlerAdapter.java
##########
@@ -26,8 +26,6 @@
* Abstract command handler.
*/
public abstract class GridRestCommandHandlerAdapter implements GridRestCommandHandler {
- /** Used cache name in case the name was not defined in a request. */
- protected static final String DFLT_CACHE_NAME = "default";
Review comment:
This config is just an example configuration. You don't have to use it. Obviously, it will be working, because cache is defined there. Real configs will not have such cache, but it still will be expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] samaitra commented on a change in pull request #8041: IGNITE-13259 Removed default cache from REST APIs
Posted by GitBox <gi...@apache.org>.
samaitra commented on a change in pull request #8041:
URL: https://github.com/apache/ignite/pull/8041#discussion_r456797662
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/GridRestCommandHandlerAdapter.java
##########
@@ -26,8 +26,6 @@
* Abstract command handler.
*/
public abstract class GridRestCommandHandlerAdapter implements GridRestCommandHandler {
- /** Used cache name in case the name was not defined in a request. */
- protected static final String DFLT_CACHE_NAME = "default";
Review comment:
The default cacheName is safe fallback when cache name is not provided in the request. It is part of rest document.
https://apacheignite.readme.io/docs/rest-api#put
When request do not have cacheName since it is optional param then this DFLT_CACHE_NAME is used https://github.com/apache/ignite/pull/8041/files#diff-a3477d5e0cfdfcceed3371fc899a9d15L30
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] samaitra commented on a change in pull request #8041: IGNITE-13259 Removed default cache from REST APIs
Posted by GitBox <gi...@apache.org>.
samaitra commented on a change in pull request #8041:
URL: https://github.com/apache/ignite/pull/8041#discussion_r458459036
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/GridRestCommandHandlerAdapter.java
##########
@@ -26,8 +26,6 @@
* Abstract command handler.
*/
public abstract class GridRestCommandHandlerAdapter implements GridRestCommandHandler {
- /** Used cache name in case the name was not defined in a request. */
- protected static final String DFLT_CACHE_NAME = "default";
Review comment:
Can you please confirm in your configuration you have this example config file.
https://github.com/apache/ignite/blob/master/examples/config/example-cache.xml#L26-L32
This has instructions on default cache config.
My understanding is when node startup then the default cache should already be available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] RealZheka commented on a change in pull request #8041: IGNITE-13259 Removed default cache from REST APIs
Posted by GitBox <gi...@apache.org>.
RealZheka commented on a change in pull request #8041:
URL: https://github.com/apache/ignite/pull/8041#discussion_r457034975
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/GridRestCommandHandlerAdapter.java
##########
@@ -26,8 +26,6 @@
* Abstract command handler.
*/
public abstract class GridRestCommandHandlerAdapter implements GridRestCommandHandler {
- /** Used cache name in case the name was not defined in a request. */
- protected static final String DFLT_CACHE_NAME = "default";
Review comment:
I understand this, but this is pointless. It is not safe fallback, because there is no "default" cache. If you will try to use any API without a name you will receive the following error:
_org.apache.ignite.IgniteCheckedException: Failed to find cache for given cache name: default_
Better to replace it by the correctly formed error message that will point to the actual problem of the request. API document will be updated accordingly when PR will be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] asfgit closed pull request #8041: IGNITE-13259 Removed default cache from REST APIs
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #8041:
URL: https://github.com/apache/ignite/pull/8041
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org