You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2018/03/22 08:48:12 UTC

[GitHub] flink issue #5732: [FLINK-9034] [FLINK-9035] [core] Fix state descriptors

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5732
  
    Concerning guarding the test assumptions: I think it is fine, because if the KryoSerializer is not duplicating properly any more (assumption violated), the test will also fail. (The problematic case would be the other way around, a serializer that does not duplicate and we check that the same instance is returned).
    
    @aljoscha Do you think this should go into 1.5 as well?
    
    @aljoscha Concerning changing `initializeSerializerUnlessSet(ExecutionConfig)` to `getSerializer(ExecutionConfig)` - I think that is a good idea, but would do that in a separate step. We need to re-work anyways a bit how we store state descriptors and obtain and reconfigure serializers.


---