You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/02/07 08:07:19 UTC
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #3871: Fixed
duplicate id error when creating VM work jobs
Spaceman1984 opened a new pull request #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871
## Description
<!--- Describe your changes in detail -->
This PR removes related VMWorkjob records when the async_job table is cleaned out.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
Fixes: #3829
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
This was tested by taking these steps:
* create an instance
* Check the async_job and vm_work_job table for matching rows
* set the job.expire.minutes to 1 minute.
* Wait a minute.
* Check the async_job and vm_work_job table for matching rows to be removed.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3871: Fixed
duplicate id error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871#issuecomment-583599818
<b>Trillian test result (tid-927)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28025 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3871-t927-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 181.73 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 179.27 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 260.48 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3871: Fixed duplicate
id error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871#issuecomment-583367321
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3871: Fixed duplicate id
error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871#issuecomment-583288125
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] richardlawley commented on issue #3871: Fixed
duplicate id error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
richardlawley commented on issue #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871#issuecomment-583332989
I don't have an easy way to test this, but the fix looks suitable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3871: Fixed duplicate id
error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871#issuecomment-583316552
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3871: Fixed duplicate
id error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871#issuecomment-583320782
As this is clearly a bug, can you target 4.13 please, @Spaceman1984 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3871: Fixed
duplicate id error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871#issuecomment-585129952
Packaging result: ✖centos6 ✖centos7 ✔debian. JID-822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3871: Fixed duplicate
id error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871#issuecomment-583329917
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3871: Fixed
duplicate id error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871#issuecomment-583316781
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3871: Fixed
duplicate id error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871#issuecomment-583330248
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3871: Fixed
duplicate id error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871#issuecomment-583330511
Packaging result: ✖centos6 ✖centos7 ✔debian. JID-783
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3871: Fixed duplicate
id error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871#issuecomment-583329343
Tageting 4.13 @DaanHoogland
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3871: Fixed
duplicate id error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871#issuecomment-583367527
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3871: Fixed
duplicate id error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871#issuecomment-585081870
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3871: Fixed duplicate id
error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871#issuecomment-585081743
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3871: Fixed
duplicate id error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871#issuecomment-583337546
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3871: Fixed duplicate id
error when creating VM work jobs
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #3871: Fixed duplicate id error when creating VM work jobs
URL: https://github.com/apache/cloudstack/pull/3871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services