You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nk1506 (via GitHub)" <gi...@apache.org> on 2024/08/07 12:22:08 UTC
[PR] Fix few of build warnings. [iceberg]
nk1506 opened a new pull request, #10899:
URL: https://github.com/apache/iceberg/pull/10899
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core, Flink: Fix build warnings [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #10899:
URL: https://github.com/apache/iceberg/pull/10899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core, Flink: Fix build warnings [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #10899:
URL: https://github.com/apache/iceberg/pull/10899#discussion_r1710827750
##########
core/src/main/java/org/apache/iceberg/view/BaseViewOperations.java:
##########
@@ -115,7 +115,7 @@ public void commit(ViewMetadata base, ViewMetadata metadata) {
}
// if the metadata is not changed, return early
- if (base == metadata) {
+ if (metadata.equals(base)) {
Review Comment:
@nk1506 you'll need to add a suppresswarning in this case to the method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core, Flink: Fix build warnings [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #10899:
URL: https://github.com/apache/iceberg/pull/10899#discussion_r1710826860
##########
core/src/main/java/org/apache/iceberg/view/BaseViewOperations.java:
##########
@@ -104,7 +104,7 @@ public ViewMetadata refresh() {
@Override
public void commit(ViewMetadata base, ViewMetadata metadata) {
// if the metadata is already out of date, reject it
- if (base != current()) {
+ if (!current().equals(base)) {
Review Comment:
@nk1506 are you going to add a suppresswarning for this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Fix few of build warnings. [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #10899:
URL: https://github.com/apache/iceberg/pull/10899#discussion_r1707196585
##########
core/src/main/java/org/apache/iceberg/view/BaseViewOperations.java:
##########
@@ -104,7 +104,7 @@ public ViewMetadata refresh() {
@Override
public void commit(ViewMetadata base, ViewMetadata metadata) {
// if the metadata is already out of date, reject it
- if (base != current()) {
+ if (!current().equals(base)) {
Review Comment:
the previous check is actually correct
##########
core/src/main/java/org/apache/iceberg/view/BaseViewOperations.java:
##########
@@ -115,7 +115,7 @@ public void commit(ViewMetadata base, ViewMetadata metadata) {
}
// if the metadata is not changed, return early
- if (base == metadata) {
+ if (metadata.equals(base)) {
Review Comment:
the previous check is actually correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Fix few of build warnings. [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #10899:
URL: https://github.com/apache/iceberg/pull/10899#discussion_r1709513215
##########
core/src/main/java/org/apache/iceberg/view/BaseViewOperations.java:
##########
@@ -104,7 +104,7 @@ public ViewMetadata refresh() {
@Override
public void commit(ViewMetadata base, ViewMetadata metadata) {
// if the metadata is already out of date, reject it
- if (base != current()) {
+ if (!current().equals(base)) {
Review Comment:
yes, in this case this warning should be ignored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Fix few of build warnings. [iceberg]
Posted by "nk1506 (via GitHub)" <gi...@apache.org>.
nk1506 commented on code in PR #10899:
URL: https://github.com/apache/iceberg/pull/10899#discussion_r1709493449
##########
core/src/main/java/org/apache/iceberg/view/BaseViewOperations.java:
##########
@@ -104,7 +104,7 @@ public ViewMetadata refresh() {
@Override
public void commit(ViewMetadata base, ViewMetadata metadata) {
// if the metadata is already out of date, reject it
- if (base != current()) {
+ if (!current().equals(base)) {
Review Comment:
<img width="1518" alt="Screenshot 2024-08-08 at 6 49 29 PM" src="https://github.com/user-attachments/assets/f22f43c2-b6ce-4a59-8a19-0c7a488f065a">
I am seeing above warning with build. Is it ignorable ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org