You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ankita Sinha <an...@freestoneinfotech.com> on 2022/09/20 11:05:36 UTC
Review Request 74129: RANGER-3920 When sync'ing users from Ldap, intermittent User/Group/UserGroup membership is missing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74129/
-----------------------------------------------------------
Review request for ranger, Madhan Neethiraj, Mehul Parikh, Monika Kachhadiya, Pradeep Agrawal, Siddhesh Phatak, Sailaja Polavarapu, and Subhrat Chaudhary.
Bugs: RANGER-3920
https://issues.apache.org/jira/browse/RANGER-3920
Repository: ranger
Description
-------
Problem Statement:
=================
Currently, Usersync sync's users/groups/usergroup in batches. In doing so, the user/group/usergroup at the end of the batch is not sync'ed.
For example consider batch is of size 1000, so batch starts from 0-999 and then next batch starts from 1001-1999. So in each batch one user/group/usergroup is missing.
Solution:
========
Updated code to handle this missing one user in each batch.
Diffs
-----
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 654b83282
Diff: https://reviews.apache.org/r/74129/diff/1/
Testing
-------
Tested with large number user/group/usergroup membership if all the user/group/usergroup membership is getting sync'ed in Ranger admin
Thanks,
Ankita Sinha
Re: Review Request 74129: RANGER-3920 When sync'ing users from Ldap, intermittent User/Group/UserGroup membership is missing
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74129/#review224687
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Sept. 20, 2022, 11:05 a.m., Ankita Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74129/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2022, 11:05 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Mehul Parikh, Monika Kachhadiya, Pradeep Agrawal, Siddhesh Phatak, Sailaja Polavarapu, and Subhrat Chaudhary.
>
>
> Bugs: RANGER-3920
> https://issues.apache.org/jira/browse/RANGER-3920
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Problem Statement:
> =================
> Currently, Usersync sync's users/groups/usergroup in batches. In doing so, the user/group/usergroup at the end of the batch is not sync'ed.
> For example consider batch is of size 1000, so batch starts from 0-999 and then next batch starts from 1001-1999. So in each batch one user/group/usergroup is missing.
>
> Solution:
> ========
> Updated code to handle this missing one user in each batch.
>
>
> Diffs
> -----
>
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 654b83282
>
>
> Diff: https://reviews.apache.org/r/74129/diff/1/
>
>
> Testing
> -------
>
> Tested with large number user/group/usergroup membership if all the user/group/usergroup membership is getting sync'ed in Ranger admin
>
>
> Thanks,
>
> Ankita Sinha
>
>
Re: Review Request 74129: RANGER-3920 When sync'ing users from Ldap, intermittent User/Group/UserGroup membership is missing
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74129/#review224845
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Sept. 20, 2022, 11:05 a.m., Ankita Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74129/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2022, 11:05 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Mehul Parikh, Monika Kachhadiya, Pradeep Agrawal, Siddhesh Phatak, Sailaja Polavarapu, and Subhrat Chaudhary.
>
>
> Bugs: RANGER-3920
> https://issues.apache.org/jira/browse/RANGER-3920
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Problem Statement:
> =================
> Currently, Usersync sync's users/groups/usergroup in batches. In doing so, the user/group/usergroup at the end of the batch is not sync'ed.
> For example consider batch is of size 1000, so batch starts from 0-999 and then next batch starts from 1001-1999. So in each batch one user/group/usergroup is missing.
>
> Solution:
> ========
> Updated code to handle this missing one user in each batch.
>
>
> Diffs
> -----
>
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 654b83282
>
>
> Diff: https://reviews.apache.org/r/74129/diff/2/
>
>
> Testing
> -------
>
> Tested with large number user/group/usergroup membership if all the user/group/usergroup membership is getting sync'ed in Ranger admin
>
>
> Thanks,
>
> Ankita Sinha
>
>
Re: Review Request 74129: RANGER-3920 When sync'ing users from Ldap, intermittent User/Group/UserGroup membership is missing
Posted by Abhishek Kumar <ab...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74129/#review224701
-----------------------------------------------------------
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Line 974 (original), 974 (patched)
<https://reviews.apache.org/r/74129/#comment313485>
PM_ADD_USERS_URI can be used at relativeUrl occurences within this file. This line can be dropped.
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Line 1076 (original), 1076 (patched)
<https://reviews.apache.org/r/74129/#comment313486>
This line can be dropped. Please see above.
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Line 1170 (original), 1170 (patched)
<https://reviews.apache.org/r/74129/#comment313487>
This line can be dropped. Please see above.
- Abhishek Kumar
On Sept. 20, 2022, 11:05 a.m., Ankita Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74129/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2022, 11:05 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Mehul Parikh, Monika Kachhadiya, Pradeep Agrawal, Siddhesh Phatak, Sailaja Polavarapu, and Subhrat Chaudhary.
>
>
> Bugs: RANGER-3920
> https://issues.apache.org/jira/browse/RANGER-3920
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Problem Statement:
> =================
> Currently, Usersync sync's users/groups/usergroup in batches. In doing so, the user/group/usergroup at the end of the batch is not sync'ed.
> For example consider batch is of size 1000, so batch starts from 0-999 and then next batch starts from 1001-1999. So in each batch one user/group/usergroup is missing.
>
> Solution:
> ========
> Updated code to handle this missing one user in each batch.
>
>
> Diffs
> -----
>
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 654b83282
>
>
> Diff: https://reviews.apache.org/r/74129/diff/1/
>
>
> Testing
> -------
>
> Tested with large number user/group/usergroup membership if all the user/group/usergroup membership is getting sync'ed in Ranger admin
>
>
> Thanks,
>
> Ankita Sinha
>
>