You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sangeeta Ravindran <sa...@gmail.com> on 2017/06/28 05:23:54 UTC

Review Request 60489: Typo in stack advisor error message for yarn and mr queue config issues

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60489/
-----------------------------------------------------------

Review request for Ambari, Di Li and Tim Thorpe.


Bugs: AMBARI-21274
    https://issues.apache.org/jira/browse/AMBARI-21274


Repository: ambari


Description
-------

If there are issues with yarn service check queue or mapreduce job queue configurations, service advisor throws an error with a typo.

Queue is not exist or not corresponds to existing YARN leaf queue


Diffs
-----

  ambari-server/src/main/resources/stacks/stack_advisor.py 3a39a34 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py b6f1965 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py e62e00c 
  contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/stack_advisor.py 5a95fe3 


Diff: https://reviews.apache.org/r/60489/diff/1/


Testing
-------

Manual testing.
Ran python tests cleanly.


Thanks,

Sangeeta Ravindran


Re: Review Request 60489: Typo in stack advisor error message for yarn and mr queue config issues

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60489/#review179097
-----------------------------------------------------------


Ship it!




Ship It!

- Di Li


On June 28, 2017, 5:23 a.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60489/
> -----------------------------------------------------------
> 
> (Updated June 28, 2017, 5:23 a.m.)
> 
> 
> Review request for Ambari, Di Li and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21274
>     https://issues.apache.org/jira/browse/AMBARI-21274
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If there are issues with yarn service check queue or mapreduce job queue configurations, service advisor throws an error with a typo.
> 
> Queue is not exist or not corresponds to existing YARN leaf queue
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 3a39a34 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py b6f1965 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py e62e00c 
>   contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/stack_advisor.py 5a95fe3 
> 
> 
> Diff: https://reviews.apache.org/r/60489/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing.
> Ran python tests cleanly.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>


Re: Review Request 60489: Typo in stack advisor error message for yarn and mr queue config issues

Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60489/#review179089
-----------------------------------------------------------


Ship it!




Ship It!

- Tim Thorpe


On June 28, 2017, 5:23 a.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60489/
> -----------------------------------------------------------
> 
> (Updated June 28, 2017, 5:23 a.m.)
> 
> 
> Review request for Ambari, Di Li and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21274
>     https://issues.apache.org/jira/browse/AMBARI-21274
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If there are issues with yarn service check queue or mapreduce job queue configurations, service advisor throws an error with a typo.
> 
> Queue is not exist or not corresponds to existing YARN leaf queue
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 3a39a34 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py b6f1965 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py e62e00c 
>   contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/stack_advisor.py 5a95fe3 
> 
> 
> Diff: https://reviews.apache.org/r/60489/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing.
> Ran python tests cleanly.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>