You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "LiZhenNet (GitHub)" <gi...@apache.org> on 2018/12/21 07:07:54 UTC
[GitHub] [incubator-dubbo] LiZhenNet opened pull request #3038: fix
telnet trace times is always 1
## What is the purpose of the change
old:
```java
if (service == null || service.length() == 0) {
service = parts.length > 0 ? parts[0] : null;
method = parts.length > 1 ? parts[1] : null;
} else {
method = parts.length > 0 ? parts[0] : null;
}
if (StringUtils.isInteger(method)) {
times = method;
method = null;
} else {
times = parts.length > 2 ? parts[2] : "1";
}
```
If invoke like this "trace xxxMethod 10" and the service is not equals null , times will not change the value ，It‘s always 1。
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3038: fix
telnet trace times is always 1
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3038?src=pr&el=h1) Report
> Merging [#3038](https://codecov.io/gh/apache/incubator-dubbo/pull/3038?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddb518de3ab3b54ec4b6a8a52db6cde1b3f58262?src=pr&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3038?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3038 +/- ##
============================================
- Coverage 63.69% 63.56% -0.13%
Complexity 75 75
============================================
Files 652 652
Lines 28199 28206 +7
Branches 4782 4784 +2
============================================
- Hits 17960 17928 -32
- Misses 7988 8022 +34
- Partials 2251 2256 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3038?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../rpc/protocol/dubbo/telnet/TraceTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9UcmFjZVRlbG5ldEhhbmRsZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9JbnZva2VUZWxuZXRIYW5kbGVyLmphdmE=) | `73.8% <70.58%> (+1.3%)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `64.1% <0%> (-17.95%)` | `0% <0%> (ø)` | |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | `0% <0%> (ø)` | |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `73.52% <0%> (-11.77%)` | `0% <0%> (ø)` | |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | `0% <0%> (ø)` | |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `70.73% <0%> (-9.76%)` | `0% <0%> (ø)` | |
| [...in/java/org/apache/dubbo/common/utils/JVMUtil.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvSlZNVXRpbC5qYXZh) | `73.58% <0%> (-7.55%)` | `0% <0%> (ø)` | |
| [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `51.42% <0%> (-5.72%)` | `0% <0%> (ø)` | |
| [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `15.78% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3038?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3038?src=pr&el=footer). Last update [ddb518d...cbcb13b](https://codecov.io/gh/apache/incubator-dubbo/pull/3038?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] LiZhenNet commented on issue #3038: fix
telnet trace times is always 1
Posted by "LiZhenNet (GitHub)" <gi...@apache.org>.
@beiwei30 Can you help me review it？
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] gudegg commented on pull request #3038:
fix telnet trace times is always 1
Posted by "gudegg (GitHub)" <gi...@apache.org>.
```java
@Data
public class User1 implements Serializable {
private static final long serialVersionUID = -4729079781904156102L;
private String name;
}
```
```java
@Data
public class User2 implements Serializable {
private static final long serialVersionUID = -2112637973209566052L;
private String name;
}
```
```java
public interface XXXService{
String hello(User1 user);
String hello(User2 user);
}
```
May find not the correct overload method; I think must **class** param when the method is overloaded.
telnet: invoke xxxService.hello({"name":"xxxx"})
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] LiZhenNet commented on issue #3038: fix
telnet trace times is always 1
Posted by "LiZhenNet (GitHub)" <gi...@apache.org>.
@beiwei30
> PR 上没看到你的留言。我的意思是，如果是 JSONObject 的话，不需要反序列话做检查，直接让它过，最终调用的时候如果不对，肯定出错的。如果对的话，按照你的逻辑，会做两次反序列化，太重了。
当情况是这样的：
```java
void methodA(ObjectA a);
void methodA(ObjectB b);
class ObjectA{
String key1;
}
class ObjectB{
String key2;
}
```
如果不进行校验，可能每次match到的都是 ObjectA 的方法。
还有另一个问题，invokeTelnetHandler 把 JsonObject 转换成对应参数类型时使用的 PojoUtils#realize，内部其实是遍历JsonObject 的 key 反射调用set 方法。 这也就造成了当我传递 ObjectB{ key2="2"} 时， 会已 ObjectA {key1:null} 进行调用。 这种情况很容易产生事故。
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] LiZhenNet commented on issue #3038: fix
telnet trace times is always 1
Posted by "LiZhenNet (GitHub)" <gi...@apache.org>.
@beiwei30
> PR 上没看到你的留言。我的意思是，如果是 JSONObject 的话，不需要反序列话做检查，直接让它过，最终调用的时候如果不对，肯定出错的。如果对的话，按照你的逻辑，会做两次反序列化，太重了。
当情况是这样的：
```java
void methodA(ObjectA a);
void methodA(ObjectB b);
```
如果不进行校验，可能每次match到的都是 ObjectA 的方法，当我传入参数是ObjectB时 ，会报错。
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] khanimteyaz commented on issue #3038: fix
telnet trace times is always 1
Posted by "khanimteyaz (GitHub)" <gi...@apache.org>.
@beiwei30 I would like to review this. would you help me to understand by functionality wise what @LiZhenNet to trying to achieve here?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] khanimteyaz commented on pull request
#3038: fix telnet trace times is always 1
Posted by "khanimteyaz (GitHub)" <gi...@apache.org>.
is there any chance parts[2] can be having non numeric number?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3038: fix
telnet trace times is always 1
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3038?src=pr&el=h1) Report
> Merging [#3038](https://codecov.io/gh/apache/incubator-dubbo/pull/3038?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/3e6ae66fde6db2edb139e59d3c5530c9196b4144?src=pr&el=desc) will **decrease** coverage by `0.84%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3038?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3038 +/- ##
============================================
- Coverage 64.3% 63.46% -0.85%
- Complexity 0 75 +75
============================================
Files 584 653 +69
Lines 26056 28252 +2196
Branches 4562 4817 +255
============================================
+ Hits 16755 17929 +1174
- Misses 7118 8050 +932
- Partials 2183 2273 +90
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3038?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../rpc/protocol/dubbo/telnet/TraceTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9UcmFjZVRlbG5ldEhhbmRsZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdSb3V0ZXIuamF2YQ==) | `33.33% <0%> (-34.53%)` | `0% <0%> (ø)` | |
| [...org/apache/dubbo/rpc/service/GenericException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zZXJ2aWNlL0dlbmVyaWNFeGNlcHRpb24uamF2YQ==) | `50% <0%> (-25%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `64.1% <0%> (-17.95%)` | `0% <0%> (ø)` | |
| [...dubbo/registry/support/ProviderInvokerWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L1Byb3ZpZGVySW52b2tlcldyYXBwZXIuamF2YQ==) | `47.82% <0%> (-15.34%)` | `0% <0%> (ø)` | |
| [...o/rpc/protocol/dubbo/telnet/ListTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9MaXN0VGVsbmV0SGFuZGxlci5qYXZh) | `65.78% <0%> (-13.76%)` | `0% <0%> (ø)` | |
| [...ava/org/apache/dubbo/common/utils/ClassHelper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ2xhc3NIZWxwZXIuamF2YQ==) | `62.85% <0%> (-13.2%)` | `0% <0%> (ø)` | |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `75.4% <0%> (-11.08%)` | `0% <0%> (ø)` | |
| [.../org/apache/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvUmVmZXJlbmNlQmVhbi5qYXZh) | `35.84% <0%> (-9.83%)` | `0% <0%> (ø)` | |
| [...org/apache/dubbo/rpc/filter/GenericImplFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvR2VuZXJpY0ltcGxGaWx0ZXIuamF2YQ==) | `53.01% <0%> (-9.64%)` | `0% <0%> (ø)` | |
| ... and [155 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3038/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3038?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3038?src=pr&el=footer). Last update [3e6ae66...160bb40](https://codecov.io/gh/apache/incubator-dubbo/pull/3038?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] LiZhenNet commented on issue #3038: fix
telnet trace times is always 1
Posted by "LiZhenNet (GitHub)" <gi...@apache.org>.
> @beiwei30 I would like to review this. would you help me to understand by functionality wise what @LiZhenNet to trying to achieve here?
I try to fix a bug about trace command in telnet。You can see “What is the purpose of the change”
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] LiZhenNet commented on issue #3038: fix
telnet trace times is always 1
Posted by "LiZhenNet (GitHub)" <gi...@apache.org>.
I have add a commit c833771 , to fix https://github.com/apache/incubator-dubbo/issues/3105
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on pull request #3038:
fix telnet trace times is always 1
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
这里校验是不是太严格了，我觉得简单一点，没有 `class` 的时候返回 `true` 就 好了。
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] LiZhenNet commented on pull request #3038:
fix telnet trace times is always 1
Posted by "LiZhenNet (GitHub)" <gi...@apache.org>.
I have fix it
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 closed pull request #3038: fix
telnet trace times is always 1
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] gudegg commented on pull request #3038:
fix telnet trace times is always 1
Posted by "gudegg (GitHub)" <gi...@apache.org>.
```java
@Data
public class User1 implements Serializable {
private static final long serialVersionUID = -4729079781904156102L;
private String name;
}
```
```java
@Data
public class User2 implements Serializable {
private static final long serialVersionUID = -2112637973209566052L;
private String name;
}
```
```java
public interface XXXService{
String hello(User1 user);
String hello(User2 user);
}
```
May find not the correct overload method; I think must **class** param when the method is overloaded.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] khanimteyaz commented on pull request
#3038: fix telnet trace times is always 1
Posted by "khanimteyaz (GitHub)" <gi...@apache.org>.
I think
`if (StringUtils.isEmpty(service))`
be better.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org