[GitHub] [cloudstack] shwstppr opened a new pull request #3248: server: disk offerings for specified domain(s) and zone(s)

[GitBox <gi...@apache.org>]

shwstppr opened a new pull request #3248: server: disk offerings for specified domain(s) and zone(s) 
URL: https://github.com/apache/cloudstack/pull/3248
 
 
   ## Description
   **Problem**: Storage offerings cannot be linked to specified multiple domain(s) and zone(s).
   **Root cause**: Storage or disk offerings are independent of zones and they can be linked to a single domain/sub-domain
   **Solution**: Storage or disk offerings will be allowed to link with specified domain(s) and zone(s). Disk offering linked with multiple domains and zones can be created both with UI and API. Existing disk offerings can be updated for linking using API. Refactored createDiskOffering and updateDiskOffering API to allow passing list of domain and zone IDs with domainids and zoneids parameter respectively. UI has been refactored to allow selecting multiple domains and zones while creating disk offering using multi-select elements. Disk offering details will now show list of linked domains and zones as a comma-separated list of names. Linked domains and zones will be stored in the cloud.disk_offering_details table in database as comma-separated list of IDs with key domainids and zoneids respectively.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   Updated create disk offering form
   ![Screenshot from 2019-03-27 17-12-50](https://user-images.githubusercontent.com/153340/55073459-ccfcd300-50b3-11e9-8c1a-2fc74cc893b9.png)
   ![Screenshot from 2019-03-27 17-11-11](https://user-images.githubusercontent.com/153340/55073466-d128f080-50b3-11e9-92c5-e5793da205c3.png)
   
   Updated disk offering details with domains and zones,
   ![Screenshot from 2019-03-27 17-07-44](https://user-images.githubusercontent.com/153340/55073505-e9007480-50b3-11e9-81c6-82c161122b64.png)
   
   Cloudmonkey API calls
   ![Screenshot from 2019-03-27 17-07-27](https://user-images.githubusercontent.com/153340/55073521-f0278280-50b3-11e9-8f50-c98bd6be3c26.png)
   ![Screenshot from 2019-03-27 17-06-14](https://user-images.githubusercontent.com/153340/55073526-f289dc80-50b3-11e9-8917-9cec20353b0d.png)
   
   
   ## How Has This Been Tested?
   From UI and cmk
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services