You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2022/07/13 09:50:15 UTC

[GitHub] [systemds] ywcb00 opened a new pull request, #1663: [MINOR] Fix FederatedLookupTable Eviction

ywcb00 opened a new pull request, #1663:
URL: https://github.com/apache/systemds/pull/1663

   Hi,
   This PR replaces the complete clear of the federated lookup table by removing only the entry of the corresponding coordinator which sent the respective _CLEAR_ request.
   Additionally, this PR changes the _FederatedStatistics.coordinatorsTrafficBytes_ list to a CopyOnWriteArrayList in order to avoid the _ConcurrentModificationException_ in a multi-tenant scenario, and executes the federated requests of the _IndexingFEDInstruction_ in the correct order to broadcast the scalar object before calling the instruction.
   
   Thanks for review :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] ywcb00 commented on pull request #1663: [MINOR] Fix FederatedLookupTable Eviction

Posted by GitBox <gi...@apache.org>.
ywcb00 commented on PR #1663:
URL: https://github.com/apache/systemds/pull/1663#issuecomment-1186877667

   I made a small change to the _Statistics_ class. We now obtain the size of the heavy hitters right after creating the separate array with entries in order to avoid nullpointer exceptions caused by wrong array lengths because another thread modifies the heavy hitters at the same time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] asfgit closed pull request #1663: [MINOR] Fix FederatedLookupTable Eviction

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1663: [MINOR] Fix FederatedLookupTable Eviction
URL: https://github.com/apache/systemds/pull/1663


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org