You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "hector.acosta@cloudera.com (Code Review)" <ge...@cloudera.org> on 2019/02/09 01:05:09 UTC
[Impala-ASF-CR] sys/types.h no longer includes sys/sysmacros.h
hector.acosta@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12419
Change subject: sys/types.h no longer includes sys/sysmacros.h
......................................................................
sys/types.h no longer includes sys/sysmacros.h
Change-Id: Ibf2cf9e4a211a6bc1b292c771386ca66979618eb
---
M be/src/util/disk-info.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/12419/1
--
To view, visit http://gerrit.cloudera.org:8080/12419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf2cf9e4a211a6bc1b292c771386ca66979618eb
Gerrit-Change-Number: 12419
Gerrit-PatchSet: 1
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
[Impala-ASF-CR] sys/types.h no longer includes sys/sysmacros.h
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12419 )
Change subject: sys/types.h no longer includes sys/sysmacros.h
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2053/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2cf9e4a211a6bc1b292c771386ca66979618eb
Gerrit-Change-Number: 12419
Gerrit-PatchSet: 1
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 01:56:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] sys/types.h no longer includes sys/sysmacros.h
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12419 )
Change subject: sys/types.h no longer includes sys/sysmacros.h
......................................................................
sys/types.h no longer includes sys/sysmacros.h
Change-Id: Ibf2cf9e4a211a6bc1b292c771386ca66979618eb
Reviewed-on: http://gerrit.cloudera.org:8080/12419
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/disk-info.cc
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf2cf9e4a211a6bc1b292c771386ca66979618eb
Gerrit-Change-Number: 12419
Gerrit-PatchSet: 2
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] sys/types.h no longer includes sys/sysmacros.h
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12419 )
Change subject: sys/types.h no longer includes sys/sysmacros.h
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2cf9e4a211a6bc1b292c771386ca66979618eb
Gerrit-Change-Number: 12419
Gerrit-PatchSet: 1
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 05:00:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] sys/types.h no longer includes sys/sysmacros.h
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12419 )
Change subject: sys/types.h no longer includes sys/sysmacros.h
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2cf9e4a211a6bc1b292c771386ca66979618eb
Gerrit-Change-Number: 12419
Gerrit-PatchSet: 1
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 01:07:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] sys/types.h no longer includes sys/sysmacros.h
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12419 )
Change subject: sys/types.h no longer includes sys/sysmacros.h
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3746/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2cf9e4a211a6bc1b292c771386ca66979618eb
Gerrit-Change-Number: 12419
Gerrit-PatchSet: 1
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 01:07:20 +0000
Gerrit-HasComments: No