You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/09/12 05:54:23 UTC

[GitHub] knight9999 opened a new pull request #405: Cocoapods support improvement, using podspec tag in plugin.xml

knight9999 opened a new pull request #405: Cocoapods support improvement, using podspec tag in plugin.xml
URL: https://github.com/apache/cordova-ios/pull/405
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   ios
   
   
   ### What does this PR do?
   - Cocoapods Support Improvement
   - Support Custom Cocoapods Repository
   - Added Test Code
   
   See https://github.com/apache/cordova-discuss/pull/108
   
   The following PR is needed to be merged first
   https://github.com/apache/cordova-common/pull/48
   
   ### What testing has been done on this change?
   
   -  Local Plugin Test (`cordova plugin add` which uses `podspec` tags to local PC)
   - `npm run test`
   
   Because this PR depends on PR (https://github.com/apache/cordova-common/pull/48), the test fails without editing package.json.
   With modified package.json, both the travis and appveyor tests passes.
   
   - (Source) https://github.com/cordova-develop/cordova-ios/commits/dev_improve_cocoapod_support_test
   - https://ci.appveyor.com/project/knight9999/cordova-ios/build/1.0.33
   - https://travis-ci.org/cordova-develop/cordova-ios/builds/427520541?utm_source=github_status&utm_medium=notification  
   
   ### Checklist
   - [x] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org