You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Nitin Mehta <ni...@citrix.com> on 2013/10/07 19:18:47 UTC
Re: Review Request 14199: Adding missing test cases: Snapshots Improvement
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/#review26715
-----------------------------------------------------------
test/integration/component/test_snapshots_improvement.py
<https://reviews.apache.org/r/14199/#comment52037>
Do check the state of the snapshot as well.
test/integration/component/test_snapshots_improvement.py
<https://reviews.apache.org/r/14199/#comment52045>
step 6 is happening before step 5
- Nitin Mehta
On Sept. 18, 2013, 11:25 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14199/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2013, 11:25 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding 5 missing test cases.
> Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly.
>
>
> Diffs
> -----
>
> test/integration/component/test_snapshots_improvement.py PRE-CREATION
> tools/marvin/marvin/asyncJobMgr.py 25818a6
>
> Diff: https://reviews.apache.org/r/14199/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14199: Adding missing test cases: Snapshots Improvement
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On Oct. 7, 2013, 10:48 p.m., Nitin Mehta wrote:
> >
>
> Nitin Mehta wrote:
> It would be great if you could show logs of a sample run. Please also let me know if all the 5 cases are tested as well
Log Added.
> On Oct. 7, 2013, 10:48 p.m., Nitin Mehta wrote:
> > test/integration/component/test_snapshots_improvement.py, line 628
> > <https://reviews.apache.org/r/14199/diff/1/?file=353158#file353158line628>
> >
> > step 6 is happening before step 5
Changed the code so that both the steps now happen asynchronously.
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/#review26715
-----------------------------------------------------------
On Sept. 18, 2013, 4:55 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14199/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2013, 4:55 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding 5 missing test cases.
> Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly.
>
>
> Diffs
> -----
>
> test/integration/component/test_snapshots_improvement.py PRE-CREATION
> tools/marvin/marvin/asyncJobMgr.py 25818a6
>
> Diff: https://reviews.apache.org/r/14199/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14199: Adding missing test cases: Snapshots Improvement
Posted by Nitin Mehta <ni...@citrix.com>.
> On Oct. 7, 2013, 5:18 p.m., Nitin Mehta wrote:
> >
It would be great if you could show logs of a sample run. Please also let me know if all the 5 cases are tested as well
- Nitin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/#review26715
-----------------------------------------------------------
On Sept. 18, 2013, 11:25 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14199/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2013, 11:25 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding 5 missing test cases.
> Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly.
>
>
> Diffs
> -----
>
> test/integration/component/test_snapshots_improvement.py PRE-CREATION
> tools/marvin/marvin/asyncJobMgr.py 25818a6
>
> Diff: https://reviews.apache.org/r/14199/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>