[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1211: DISPATCH-836 Add a .c file for every (non-private) include file

[GitBox <gi...@apache.org>]

kgiusti commented on a change in pull request #1211:
URL: https://github.com/apache/qpid-dispatch/pull/1211#discussion_r631820969



##########
File path: src/CMakeLists.txt
##########
@@ -101,25 +111,28 @@ set(qpid_dispatch_SOURCES
   router_core/terminus.c
   router_core/transfer.c
   router_core/core_timer.c
+  router_core/module.c
   router_core/modules/edge_router/module.c
   router_core/modules/edge_router/addr_proxy.c
   router_core/modules/edge_router/connection_manager.c
   router_core/modules/edge_router/link_route_proxy.c
   router_core/modules/edge_router/edge_mgmt.c
   router_core/modules/test_hooks/core_test_hooks.c
   router_core/modules/edge_addr_tracking/edge_addr_tracking.c
-  router_core/modules/address_lookup_server/address_lookup_server.c
+  router_core/modules/address_lookup_server/address_lookup_utils.c

Review comment:
       My $0.02:
   
   The address lookup stuff is only used by router-core modules.  It's not used by I/O threads, for example.  This means that we should probably "hide" the functions that are in address_lookup_utils.c by moving that file into router_core/modules/address_lookup_server directory.
   
   Then I would move the address_lookup_server.h file out of the general include/qpid/dispatch directory and put it in src/router_core/ directory.
   
   These changes would result in moving the address lookup stuff into the router_core module, which seems better to me since the address lookup functionality is only to be used by the router_core.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org