You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/11/23 07:03:45 UTC
[GitHub] [rocketmq] cserwen opened a new pull request #3526: Avoid Broker from printing too many pop-related logs
cserwen opened a new pull request #3526:
URL: https://github.com/apache/rocketmq/pull/3526
**Make sure set the target branch to `develop`**
## What is the purpose of the change
#3525
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen closed pull request #3526: [ISSUE #3525] Avoid Broker from printing too many pop-related logs when enablePopLos is false
Posted by GitBox <gi...@apache.org>.
cserwen closed pull request #3526:
URL: https://github.com/apache/rocketmq/pull/3526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] odbozhou commented on a change in pull request #3526: [ISSUE #3525] Avoid Broker from printing too many pop-related logs when enablePopLos is false
Posted by GitBox <gi...@apache.org>.
odbozhou commented on a change in pull request #3526:
URL: https://github.com/apache/rocketmq/pull/3526#discussion_r755728283
##########
File path: broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java
##########
@@ -218,8 +220,10 @@ public PullResult getMessage(String group, String topic, int queueId, long offse
case OFFSET_OVERFLOW_ONE:
case OFFSET_TOO_SMALL:
pullStatus = PullStatus.OFFSET_ILLEGAL;
- POP_LOGGER.warn("offset illegal. GetMessageStatus={}, topic={}, groupId={}, requestOffset={}",
- getMessageResult.getStatus(), topic, group, offset);
+ if (brokerController.getBrokerConfig().isEnablePopLog()) {
+ POP_LOGGER.warn("offset illegal. GetMessageStatus={}, topic={}, groupId={}, requestOffset={}",
Review comment:
The warn log is necessary, it may be some abnormal scenarios
##########
File path: broker/src/main/java/org/apache/rocketmq/broker/processor/PopBufferMergeService.java
##########
@@ -442,7 +442,9 @@ public boolean addCk(PopCheckPoint point, int reviveQueueId, long reviveQueueOff
}
if (this.counter.get() > brokerController.getBrokerConfig().getPopCkMaxBufferSize()) {
- POP_LOGGER.warn("[PopBuffer]add ck, max size, {}, {}", point, this.counter.get());
+ if (brokerController.getBrokerConfig().isEnablePopLog()) {
+ POP_LOGGER.warn("[PopBuffer]add ck, max size, {}, {}", point, this.counter.get());
Review comment:
warn log is necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen commented on pull request #3526: [ISSUE #3525] Avoid Broker from printing too many pop-related logs when enablePopLos is false
Posted by GitBox <gi...@apache.org>.
cserwen commented on pull request #3526:
URL: https://github.com/apache/rocketmq/pull/3526#issuecomment-977590932
@odbozhou Thanks. That is my fault. These codes do not need to be changed. We only need to set `enablePopLog` to false to achieve the purpose of reducing logs:satisfied:.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org