You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2024/12/09 19:00:46 UTC
[PR] Force portable TestStream to use the Nested Coder context throughout. [beam]
lostluck opened a new pull request, #33334:
URL: https://github.com/apache/beam/pull/33334
Coder Contexts are largely deprecated as a notion in Beam, and aren't used, with the default being the "nested" coder context instead of the Outer context. There are a few places though that still set "outer coder context" by default, notably in the CoderUtils helper methods.
Where this manifests for TestStream is that CoderUtils is used to take elements and convert them into byte buffers when moved portably. While *most* coders now ignore the difference, for various legacy reasons, the KVCoder still pipes the context to the *value* coder, and some coders still understand and use the difference. In this case, the StringUTF8 coder, when given the Outer context, doesn't length prefix the string.
This leads to TestStream values being encoded in weird ways, that don't translate portably. eg. If the values are KV<String, String> the Key will be length prefixed, but the value will not be. This will ultimately cause a break at test run time, because the CoderUtils path isn't used in decoding over Beam Portability, but the normal decoder path, which wouldn't provide the Outer context.
This is likely what's caused difficulty in using TestStream in non-Java SDKs.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Force portable TestStream to use the Nested Coder context throughout. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #33334: Force portable TestStream to use the Nested Coder context throughout.
URL: https://github.com/apache/beam/pull/33334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Force portable TestStream to use the Nested Coder context throughout. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33334:
URL: https://github.com/apache/beam/pull/33334#issuecomment-2660909572
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Force portable TestStream to use the Nested Coder context throughout. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33334:
URL: https://github.com/apache/beam/pull/33334#issuecomment-2529183373
## Test Results
15 tests +14 4 ✅ + 3 26m 3s ⏱️ + 11m 34s
12 suites +11 0 💤 ± 0
12 files +11 11 ❌ +11
For more details on these failures, see [this check](https://github.com/apache/beam/runs/34150965485).
Results for commit f5dc00ba. ± Comparison against base commit 2344fdc4.
<details>
<summary>This pull request <b>removes</b> 1 and <b>adds</b> 15 tests. <i>Note that renamed tests count towards both.</i></summary>
```
apache_beam.examples.streaming_wordcount_it_test.StreamingWordCountIT ‑ test_streaming_wordcount_it
```
```
org.apache.beam.examples.complete.AutoCompleteIT ‑ testE2EAutoComplete
org.apache.beam.examples.complete.TfIdfIT ‑ testE2ETfIdf
org.apache.beam.examples.complete.TopWikipediaSessionsIT ‑ testE2ETopWikiPages
org.apache.beam.examples.complete.TrafficMaxLaneFlowIT ‑ testE2ETrafficMaxLaneFlow
org.apache.beam.examples.complete.TrafficRoutesIT ‑ testE2ETrafficRoutes
org.apache.beam.examples.cookbook.BigQueryTornadoesIT ‑ testE2EBigQueryTornadoesWithExport
org.apache.beam.examples.cookbook.BigQueryTornadoesIT ‑ testE2EBigQueryTornadoesWithExportUsingQuery
org.apache.beam.examples.cookbook.BigQueryTornadoesIT ‑ testE2eBigQueryTornadoesWithStorageApi
org.apache.beam.examples.cookbook.BigQueryTornadoesIT ‑ testE2eBigQueryTornadoesWithStorageApiUsingQuery
org.apache.beam.examples.cookbook.CombinePerKeyExamplesIT ‑ testE2ECombinePerKey
…
```
</details>
[test-results]:data:application/gzip;base64,H4sIADBEV2cC/02MSw7CIBBAr9KwdgFUQLyMoXRIiG0xfFaNdxdQgd28NzPvRMZuENB9IvQyoZBs7LQmr6J1R2HG52zyMtY1+8MjJK2zuXbxtK8scBNG2a38kGbAe+d/Nz4drVjmMfjl3qs85qoYa9rtu40ZkGGrxnhRwCRRSiw3RjVVs+ACBBUgZ2ZAAhfo/QFVsyLhBAEAAA==
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Force portable TestStream to use the Nested Coder context throughout. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33334:
URL: https://github.com/apache/beam/pull/33334#issuecomment-2645405446
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Force portable TestStream to use the Nested Coder context throughout. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33334:
URL: https://github.com/apache/beam/pull/33334#issuecomment-2529449111
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org