[GitHub] [pinot] jvenant commented on a diff in pull request #10731: set reader spec config and add test

["jvenant (via GitHub)" <gi...@apache.org>]

jvenant commented on code in PR #10731:
URL: https://github.com/apache/pinot/pull/10731#discussion_r1189460774


##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/segmentgenerationandpush/SegmentGenerationAndPushTaskExecutor.java:
##########
@@ -287,6 +287,9 @@ protected SegmentGenerationTaskSpec generateTaskSpec(Map<String, String> taskCon
       recordReaderSpec.setDataFormat(taskConfigs.get(BatchConfigProperties.INPUT_FORMAT));
       recordReaderSpec.setClassName(taskConfigs.get(BatchConfigProperties.RECORD_READER_CLASS));
       recordReaderSpec.setConfigClassName(taskConfigs.get(BatchConfigProperties.RECORD_READER_CONFIG_CLASS));
+      recordReaderSpec.setConfigs(

Review Comment:
   Fixed in bb90840fffa9e1f3d2f03af2f8270127bfe91787



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org