You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by DIPAYAN BHOWMICK <di...@gmail.com> on 2015/09/02 22:04:50 UTC
Review Request 38066: Exceptions encountered in Ambari Views are
missing in ambari-server.log
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38066/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-12249
https://issues.apache.org/jira/browse/AMBARI-12249
Repository: ambari
Description
-------
Previously, in Slider view, the logger instances were initialized from log4j, where as in other views logger instances were instantiated from Slf4J. So, the log statements in slider view were not getting added to 'ambari-server.log'. Changed the logger instantiation to slf4j.
Diffs
-----
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppTypesResourceProvider.java 725c18a
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppsAlerts.java 4eb54d5
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppsConfiguration.java 05c7687
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppsResourceProvider.java 0c0dd12
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppsViewControllerImpl.java ca50e33
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/SliderAppsResource.java 9d17bce
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/AmbariHttpClient.java c3f4e38
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/BaseHttpClient.java bfa1750
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/Metric.java 3f5a39d
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/SliderAppJmxHelper.java d3ca1e4
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/SliderAppMasterClient.java f0cc18b
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/SliderAppMetricsHelper.java 6d5e89e
Diff: https://reviews.apache.org/r/38066/diff/
Testing
-------
Unit tests executed. Tested in Local VM.
Thanks,
DIPAYAN BHOWMICK
Re: Review Request 38066: Exceptions encountered in Ambari Views are
missing in ambari-server.log
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38066/#review97781
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On Sept. 2, 2015, 8:04 p.m., DIPAYAN BHOWMICK wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38066/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 8:04 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-12249
> https://issues.apache.org/jira/browse/AMBARI-12249
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Previously, in Slider view, the logger instances were initialized from log4j, where as in other views logger instances were instantiated from Slf4J. So, the log statements in slider view were not getting added to 'ambari-server.log'. Changed the logger instantiation to slf4j.
>
>
> Diffs
> -----
>
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppTypesResourceProvider.java 725c18a
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppsAlerts.java 4eb54d5
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppsConfiguration.java 05c7687
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppsResourceProvider.java 0c0dd12
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppsViewControllerImpl.java ca50e33
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/SliderAppsResource.java 9d17bce
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/AmbariHttpClient.java c3f4e38
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/BaseHttpClient.java bfa1750
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/Metric.java 3f5a39d
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/SliderAppJmxHelper.java d3ca1e4
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/SliderAppMasterClient.java f0cc18b
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/SliderAppMetricsHelper.java 6d5e89e
>
> Diff: https://reviews.apache.org/r/38066/diff/
>
>
> Testing
> -------
>
> Unit tests executed. Tested in Local VM.
>
>
> Thanks,
>
> DIPAYAN BHOWMICK
>
>