[GitHub] [iceberg] flyrain commented on a diff in pull request #6304: API, Core: Add groupingKey to ScanTaskGroup

[GitBox <gi...@apache.org>]

flyrain commented on code in PR #6304:
URL: https://github.com/apache/iceberg/pull/6304#discussion_r1034212530


##########
api/src/main/java/org/apache/iceberg/ScanTaskGroup.java:
##########
@@ -26,6 +26,24 @@
  * @param <T> the type of scan tasks
  */
 public interface ScanTaskGroup<T extends ScanTask> extends ScanTask {
+  /**
+   * Returns a grouping key for this task group.
+   *
+   * <p>Tasks may produce records that belong to a specific group of data (e.g. partition). It may
+   * be beneficial to preserve that grouping while combining tasks into groups if query engines can
+   * leverage that information to avoid shuffles. Grouping keys indicate how data is split between

Review Comment:
   Nit: 
   `It may be beneficial to preserve that grouping while combining tasks into groups if query engines can leverage that information to avoid shuffles.` ->
   `Query engines could leverage the grouping key to avoid shuffles by combining tasks within the same group.` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org