[GitHub] [iceberg] Fokko commented on a diff in pull request #6775: Python: Add positional deletes

["Fokko (via GitHub)" <gi...@apache.org>]

Fokko commented on code in PR #6775:
URL: https://github.com/apache/iceberg/pull/6775#discussion_r1183675674


##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -498,6 +503,96 @@ def expression_to_pyarrow(expr: BooleanExpression) -> pc.Expression:
     return boolean_expression_visit(expr, _ConvertToArrowExpression())
 
 
+@lru_cache

Review Comment:
   Good question, and yes:
   ```
   ➜  iceberg git:(master) python3
   Python 3.11.3 (main, Apr  7 2023, 20:13:31) [Clang 14.0.0 (clang-1400.0.29.202)] on darwin
   Type "help", "copyright", "credits" or "license" for more information.
   >>> from functools import lru_cache
   >>> 
   >>> import random
   >>> 
   >>> @lru_cache
   ... def get_random_number(something: str, **kwargs):
   ...     return random.randint(0, 1925)
   ... 
   >>> get_random_number('a', b=1)
   827
   >>> get_random_number('a', b=1)
   827
   >>> get_random_number('a', b=2)
   540
   >>> get_random_number('a', b=3)
   1820
   >>> get_random_number('a', b=3)
   1820
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org