You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Carl Steinbach <ca...@cloudera.com> on 2010/09/02 00:37:21 UTC
Review Request: HIVE-1609: Support partition filtering in metastore
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/763/
-----------------------------------------------------------
Review request for Hive Developers.
Summary
-------
HIVE-1609: Support partition filtering in metastore
This addresses bug HIVE-1609.
http://issues.apache.org/jira/browse/HIVE-1609
Diffs
-----
trunk/metastore/build.xml 991274
trunk/metastore/if/hive_metastore.thrift 991397
trunk/metastore/ivy.xml 991274
trunk/metastore/src/gen-cpp/ThriftHiveMetastore.h 991274
trunk/metastore/src/gen-cpp/ThriftHiveMetastore.cpp 991274
trunk/metastore/src/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 991274
trunk/metastore/src/gen-java/org/apache/hadoop/hive/metastore/parser/FilterParser.java PRE-CREATION
trunk/metastore/src/gen-java/org/apache/hadoop/hive/metastore/parser/FilterParserConstants.java PRE-CREATION
trunk/metastore/src/gen-java/org/apache/hadoop/hive/metastore/parser/FilterParserTokenManager.java PRE-CREATION
trunk/metastore/src/gen-java/org/apache/hadoop/hive/metastore/parser/ParseException.java PRE-CREATION
trunk/metastore/src/gen-java/org/apache/hadoop/hive/metastore/parser/SimpleCharStream.java PRE-CREATION
trunk/metastore/src/gen-java/org/apache/hadoop/hive/metastore/parser/Token.java PRE-CREATION
trunk/metastore/src/gen-java/org/apache/hadoop/hive/metastore/parser/TokenMgrError.java PRE-CREATION
trunk/metastore/src/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 991274
trunk/metastore/src/gen-php/ThriftHiveMetastore.php 991274
trunk/metastore/src/gen-py/hive_metastore/ThriftHiveMetastore-remote 991274
trunk/metastore/src/gen-py/hive_metastore/ThriftHiveMetastore.py 991274
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 991274
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 991274
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 991274
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 991274
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java PRE-CREATION
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/parser/filter_parser.jj PRE-CREATION
trunk/metastore/src/model/package.jdo 991274
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 991274
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 991274
Diff: http://review.cloudera.org/r/763/diff
Testing
-------
Thanks,
Carl
Re: Review Request: HIVE-1609: Support partition filtering in metastore
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/763/#review1075
-----------------------------------------------------------
trunk/metastore/build.xml
<http://review.cloudera.org/r/763/#comment3422>
Hive already uses ANTLR. Introducing a dependency on a new parser generator (especially one that the Pig devs are already unhappy with) seems unwise from a maintenance and build perspective. Can you please rewrite this to use ANTLR?
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<http://review.cloudera.org/r/763/#comment3424>
get_partitions_by_filter() should throw Unknown[DB|Table]Exception if either the database or table do not exist.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
<http://review.cloudera.org/r/763/#comment3425>
listPartitionsByFilter() should also throw UnknownDBException and UnknownTableException.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
<http://review.cloudera.org/r/763/#comment3426>
Please use StringBuilder instead.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
<http://review.cloudera.org/r/763/#comment3427>
The query should have an ORDER clause on MPartition.partitionName in order to insure that the results are deterministic.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
<http://review.cloudera.org/r/763/#comment3428>
Minor organization issue: why does this method appear here instead of next to listMPartitionsByFilter()?
- Carl
On 2010-09-01 15:37:21, Carl Steinbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/763/
> -----------------------------------------------------------
>
> (Updated 2010-09-01 15:37:21)
>
>
> Review request for Hive Developers.
>
>
> Summary
> -------
>
> HIVE-1609: Support partition filtering in metastore
>
>
> This addresses bug HIVE-1609.
> http://issues.apache.org/jira/browse/HIVE-1609
>
>
> Diffs
> -----
>
> trunk/metastore/build.xml 991274
> trunk/metastore/if/hive_metastore.thrift 991397
> trunk/metastore/ivy.xml 991274
> trunk/metastore/src/gen-cpp/ThriftHiveMetastore.h 991274
> trunk/metastore/src/gen-cpp/ThriftHiveMetastore.cpp 991274
> trunk/metastore/src/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 991274
> trunk/metastore/src/gen-java/org/apache/hadoop/hive/metastore/parser/FilterParser.java PRE-CREATION
> trunk/metastore/src/gen-java/org/apache/hadoop/hive/metastore/parser/FilterParserConstants.java PRE-CREATION
> trunk/metastore/src/gen-java/org/apache/hadoop/hive/metastore/parser/FilterParserTokenManager.java PRE-CREATION
> trunk/metastore/src/gen-java/org/apache/hadoop/hive/metastore/parser/ParseException.java PRE-CREATION
> trunk/metastore/src/gen-java/org/apache/hadoop/hive/metastore/parser/SimpleCharStream.java PRE-CREATION
> trunk/metastore/src/gen-java/org/apache/hadoop/hive/metastore/parser/Token.java PRE-CREATION
> trunk/metastore/src/gen-java/org/apache/hadoop/hive/metastore/parser/TokenMgrError.java PRE-CREATION
> trunk/metastore/src/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 991274
> trunk/metastore/src/gen-php/ThriftHiveMetastore.php 991274
> trunk/metastore/src/gen-py/hive_metastore/ThriftHiveMetastore-remote 991274
> trunk/metastore/src/gen-py/hive_metastore/ThriftHiveMetastore.py 991274
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 991274
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 991274
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 991274
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 991274
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java PRE-CREATION
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/parser/filter_parser.jj PRE-CREATION
> trunk/metastore/src/model/package.jdo 991274
> trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 991274
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 991274
>
> Diff: http://review.cloudera.org/r/763/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Carl
>
>