You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Philip Martin <ph...@codematters.co.uk> on 2004/10/23 13:06:32 UTC

Re: svn commit: r11589 - trunk/subversion/libsvn_repos

dionisos@tigris.org writes:

> Author: dionisos
> Date: Sat Oct 23 03:23:02 2004
> New Revision: 11589
>
> Modified:
>    trunk/subversion/libsvn_repos/repos.c
>    trunk/subversion/libsvn_repos/repos.h
> Log:

> ==============================================================================
> --- trunk/subversion/libsvn_repos/repos.c	(original)
> +++ trunk/subversion/libsvn_repos/repos.c	Sat Oct 23 03:23:02 2004
> @@ -65,6 +65,13 @@
>  
>  
>  const char *
> +svn_repos_passwd (svn_repos_t *repos, apr_pool_t *pool)

Re: svn commit: r11589 - trunk/subversion/libsvn_repos

Posted by Erik Huelsmann <e....@gmx.net>.
> dionisos@tigris.org writes:
> 
> > Author: dionisos
> > Date: Sat Oct 23 03:23:02 2004
> > New Revision: 11589
> >
> > Modified:
> >    trunk/subversion/libsvn_repos/repos.c
> >    trunk/subversion/libsvn_repos/repos.h
> > Log:
> 
> >
>
==============================================================================
> > --- trunk/subversion/libsvn_repos/repos.c	(original)
> > +++ trunk/subversion/libsvn_repos/repos.c	Sat Oct 23 03:23:02 2004
> > @@ -65,6 +65,13 @@
> >  
> >  
> >  const char *
> > +svn_repos_passwd (svn_repos_t *repos, apr_pool_t *pool)
> 
> >From its name, and the fact that it is not static, this appears to be
> a public interface, yet it doesn't appear in a header file.

Arrrgh!

>  What's going on?

/me should *think*

> > +{
> > +  return svn_path_join (repos->conf_path, SVN_REPOS__CONF_PASSWD,
> pool);
> > +}

I only use the function once, and it does not serve a general purpose, so
I'll move this line into create_conf() function giving it directly as
argument to svn_io_create_file().

In which case I could also remove the new constant from the repos.h.

bye,


Erik.

-- 
+++ GMX DSL Premiumtarife 3 Monate gratis* + WLAN-Router 0,- EUR* +++
Clevere DSL-Nutzer wechseln jetzt zu GMX: http://www.gmx.net/de/go/dsl


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org