You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "xuzhiwen1255 (via GitHub)" <gi...@apache.org> on 2023/04/14 01:39:00 UTC
[GitHub] [flink-connector-jdbc] xuzhiwen1255 opened a new pull request, #28: [hotfix] [doc] Fix the configuration item error of docs/content.zh/docs/connectors/table/jdbc.md
xuzhiwen1255 opened a new pull request, #28:
URL: https://github.com/apache/flink-connector-jdbc/pull/28
## What is the purpose of the change
Fix lookup.cache.max-rows in docs/content.zh/docs/connectors/table/jdbc.md configuration
## Brief change log
Fix option(lookup.cache.max-rows -> lookup.partial-cache.max-rows ) in jdbc.md
## Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no
## Documentation
Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-jdbc] xuzhiwen1255 commented on pull request #28: [hotfix] [doc] Fix the configuration item error of docs/content.zh/docs/connectors/table/jdbc.md
Posted by "xuzhiwen1255 (via GitHub)" <gi...@apache.org>.
xuzhiwen1255 commented on PR #28:
URL: https://github.com/apache/flink-connector-jdbc/pull/28#issuecomment-1498564999
@MartijnVisser His description is correct, but his configuration key is incorrectly named.
Because he's using the old key.
But when I look at the code,jdbc collector does not use the latest cacheOptions, so it should not be changed. Do we need to replace the obsolete options with the latest options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-jdbc] xuzhiwen1255 commented on pull request #28: [hotfix] [doc] Fix the configuration item error of docs/content.zh/docs/connectors/table/jdbc.md
Posted by "xuzhiwen1255 (via GitHub)" <gi...@apache.org>.
xuzhiwen1255 commented on PR #28:
URL: https://github.com/apache/flink-connector-jdbc/pull/28#issuecomment-1507811739
@MartijnVisser Sorry, i made a mistake, it should be that the current jdbc lookup configuration is obsolete, and we should replace it with the latest lookup configuration.
eg. Configure ``lookup.cache.max-rows`` to replace ``lookup.partial-cache.max-rows`` ..
Otherwise, when users configure according to the official website information, they are still using the old configuration parameters instead of the latest ones.
I think we should modify all obsolete parameters and replace them with the latest lookup configuration.
What do you think? @MartijnVisser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-jdbc] boring-cyborg[bot] commented on pull request #28: [hotfix] [doc] Fix the configuration item error of docs/content.zh/docs/connectors/table/jdbc.md
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #28:
URL: https://github.com/apache/flink-connector-jdbc/pull/28#issuecomment-1473431515
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-jdbc] xuzhiwen1255 closed pull request #28: [hotfix] [doc] Fix the configuration item error of docs/content.zh/docs/connectors/table/jdbc.md
Posted by "xuzhiwen1255 (via GitHub)" <gi...@apache.org>.
xuzhiwen1255 closed pull request #28: [hotfix] [doc] Fix the configuration item error of docs/content.zh/docs/connectors/table/jdbc.md
URL: https://github.com/apache/flink-connector-jdbc/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-jdbc] xuzhiwen1255 closed pull request #28: [hotfix] [doc] Fix the configuration item error of docs/content.zh/docs/connectors/table/jdbc.md
Posted by "xuzhiwen1255 (via GitHub)" <gi...@apache.org>.
xuzhiwen1255 closed pull request #28: [hotfix] [doc] Fix the configuration item error of docs/content.zh/docs/connectors/table/jdbc.md
URL: https://github.com/apache/flink-connector-jdbc/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org