You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2016/01/21 03:52:39 UTC

[jira] [Commented] (HBASE-15126) HBaseFsck's checkRegionBoundaries function set incorrect 'storesFirstKey'

    [ https://issues.apache.org/jira/browse/HBASE-15126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109950#comment-15109950 ] 

Ted Yu commented on HBASE-15126:
--------------------------------

Table name still doesn't match test name:
{code}
588	  public void testRegionBoundariesCheckWithFlushTable() throws Exception {
589	    HBaseFsck hbck = doFsck(conf, false);
590	    assertNoErrors(hbck); // no errors
591	    TableName table = TableName.valueOf("testRegionBoundariesCheckWithTestFlushTable");
{code}

> HBaseFsck's checkRegionBoundaries function set incorrect 'storesFirstKey'
> -------------------------------------------------------------------------
>
>                 Key: HBASE-15126
>                 URL: https://issues.apache.org/jira/browse/HBASE-15126
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 2.0.0
>            Reporter: chenrongwei
>            Assignee: chenrongwei
>         Attachments: HBASE-15126-v001.patch, HBASE-15126-v002.patch, HBASE-15126-v003.patch, HBASE-15126-v004.patch, HBASE-15126-v005.patch
>
>
> HBaseFsck's checkRegionBoundaries function set the 'currentRegionBoundariesInformation.storesFirstKey'  was incorrect.I think it should be set like below,
> currentRegionBoundariesInformation.storesFirstKey = keyOnly(storeFirstKey);
> but current the 'currentRegionBoundariesInformation.storesFirstKey ' is just set to 'storeFirstKey',which will cause to comparator.compare(currentRegionBoundariesInformation.storesFirstKey,
>             currentRegionBoundariesInformation.metaFirstKey)  get a wrong result.  Because it just compared the rowkey's length.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)