You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Xiangrui Meng (JIRA)" <ji...@apache.org> on 2015/05/20 08:05:59 UTC
[jira] [Comment Edited] (SPARK-7537) Audit new public Scala APIs
for MLlib 1.4
[ https://issues.apache.org/jira/browse/SPARK-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551863#comment-14551863 ]
Xiangrui Meng edited comment on SPARK-7537 at 5/20/15 6:05 AM:
---------------------------------------------------------------
1. toPMML should be experimental. Shall we keep 4 toPMML methods?
1. NaiveBayes.modelType -> lowercase letters
1. DistributedLDAModel.topicDistributions is not Java friendly
1. LDAOptimizer/EMLDAOptimizer/OnlineLDAOptimizer -> private?
1. Mention the Java-friendly factory method in the RankingMetrics constructor.
1. Graduate Statistics from Experimental?
1. Statistics.kernelDensity API doesn't really match kernel density APIs from other Statistics libraries.
was (Author: mengxr):
1. toPMML should be experimental. Shall we keep 4 toPMML methods?
1. NaiveBayes.modelType -> lowercase letters
1. DistributedLDAModel.topicDistributions is not Java friendly
1. LDAOptimizer/EMLDAOptimizer/OnlineLDAOptimizer should be private.
1. Mention the Java-friendly factory method in the RankingMetrics constructor.
1. Graduate Statistics from Experimental?
1. Statistics.kernelDensity API doesn't really match kernel density APIs from other Statistics libraries.
> Audit new public Scala APIs for MLlib 1.4
> -----------------------------------------
>
> Key: SPARK-7537
> URL: https://issues.apache.org/jira/browse/SPARK-7537
> Project: Spark
> Issue Type: Sub-task
> Components: MLlib
> Reporter: Joseph K. Bradley
> Assignee: Xiangrui Meng
>
> Audit new public Scala APIs added to MLlib in 1.4. Take note of:
> * Protected/public classes or methods. If access can be more private, then it should be.
> * Documentation: Missing? Bad links or formatting?
> *Make sure to check the object doc!*
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org