You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cayenne.apache.org by Andrus Adamchik <an...@objectstyle.org> on 2008/10/02 21:17:54 UTC

SmartNamingStrategyTest unit test failure

Hi Andrey,

Is this test failing cause SmartNamingStrategy is still work in  
progress?

junit.framework.ComparisonFailure: expected:<toPerson> but  
was:<shippingAddress>
	at junit.framework.Assert.assertEquals(Assert.java:81)
	at junit.framework.Assert.assertEquals(Assert.java:87)
	at  
org 
.apache 
.cayenne 
.modeler 
.util 
.SmartNamingStrategyTest.testStrategy(SmartNamingStrategyTest.java:44)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at  
sun 
.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java: 
39)
	at  
sun 
.reflect 
.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java: 
25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at junit.framework.TestCase.runTest(TestCase.java:154)
	at junit.framework.TestCase.runBare(TestCase.java:127)
	at junit.framework.TestResult$1.protect(TestResult.java:106)
	at junit.framework.TestResult.runProtected(TestResult.java:124)
	at junit.framework.TestResult.run(TestResult.java:109)
	at junit.framework.TestCase.run(TestCase.java:118)
	at junit.framework.TestSuite.runTest(TestSuite.java:208)
	at junit.framework.TestSuite.run(TestSuite.java:203)
	at  
org 
.eclipse 
.jdt 
.internal 
.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java: 
130)
	at  
org 
.eclipse 
.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at  
org 
.eclipse 
.jdt 
.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java: 
460)
	at  
org 
.eclipse 
.jdt 
.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java: 
673)
	at  
org 
.eclipse 
.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java: 
386)
	at  
org 
.eclipse 
.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java: 
196)


Thanks,
Andrus

Re: SmartNamingStrategyTest unit test failure

Posted by Andrus Adamchik <an...@objectstyle.org>.

On Oct 3, 2008, at 10:23 AM, Andrey Razumovsky wrote:

> Sorry this was a bad test. By the way, could you check new strategy  
> with
> your databases? I like the way it works with mine, but different  
> developers
> have different approaches for naming..

Thanks for the quick fix. Cool, I will take a look at the new feature.

> Other question is, is it OK to commit failing cases which correspond  
> to bugs
> that are not fixed (I'm not talking about this strategy issue)?

Generally we are trying to avoid that. E.g. by commenting out failing  
lines (implying that whoever did that knows that the problem needs to  
be fixed).

Andrus

Re: SmartNamingStrategyTest unit test failure

Posted by Andrey Razumovsky <ra...@gmail.com>.

Hi Andrus,

Sorry this was a bad test. By the way, could you check new strategy with
your databases? I like the way it works with mine, but different developers
have different approaches for naming..
Other question is, is it OK to commit failing cases which correspond to bugs
that are not fixed (I'm not talking about this strategy issue)?

2008/10/2, Andrus Adamchik <an...@objectstyle.org>:
>
> Hi Andrey,
>
> Is this test failing cause SmartNamingStrategy is still work in progress?
>
> junit.framework.ComparisonFailure: expected:<toPerson> but
> was:<shippingAddress>
>        at junit.framework.Assert.assertEquals(Assert.java:81)
>        at junit.framework.Assert.assertEquals(Assert.java:87)
>        at
> org.apache.cayenne.modeler.util.SmartNamingStrategyTest.testStrategy(SmartNamingStrategyTest.java:44)
>        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>        at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>        at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>        at java.lang.reflect.Method.invoke(Method.java:585)
>        at junit.framework.TestCase.runTest(TestCase.java:154)
>        at junit.framework.TestCase.runBare(TestCase.java:127)
>        at junit.framework.TestResult$1.protect(TestResult.java:106)
>        at junit.framework.TestResult.runProtected(TestResult.java:124)
>        at junit.framework.TestResult.run(TestResult.java:109)
>        at junit.framework.TestCase.run(TestCase.java:118)
>        at junit.framework.TestSuite.runTest(TestSuite.java:208)
>        at junit.framework.TestSuite.run(TestSuite.java:203)
>        at
> org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
>        at
> org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
>        at
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
>        at
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
>        at
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
>        at
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)
>
>
> Thanks,
> Andrus
>
>