You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "feiniaofeiafei (via GitHub)" <gi...@apache.org> on 2024/03/14 07:26:22 UTC
[PR] [Fix](nereids)Fix Bug when grouping has same grouping set [doris]
feiniaofeiafei opened a new pull request, #32235:
URL: https://github.com/apache/doris/pull/32235
fix sql like select a from t1 group by grouping sets((a),(a));
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids)Fix Bug when grouping has same grouping set [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32235:
URL: https://github.com/apache/doris/pull/32235#issuecomment-1996791293
<details>
<summary>TPC-H: <b>Total hot run time: 38078 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 526dc184a1dd5c5329053142ed578f8951a9814d, data reload: false
------ Round 1 ----------------------------------
q1 17637 4204 4094 4094
q2 2017 140 141 140
q3 10614 1063 881 881
q4 7083 706 676 676
q5 7459 2662 2585 2585
q6 185 124 123 123
q7 1195 800 791 791
q8 9387 2021 2003 2003
q9 7271 6427 6425 6425
q10 8548 3509 3593 3509
q11 433 227 214 214
q12 770 303 289 289
q13 18154 2835 2827 2827
q14 278 242 243 242
q15 507 451 450 450
q16 499 389 389 389
q17 940 528 519 519
q18 7089 6450 6377 6377
q19 1770 1394 1369 1369
q20 555 285 282 282
q21 6266 3578 3576 3576
q22 348 330 317 317
Total cold run time: 109005 ms
Total hot run time: 38078 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4054 4064 4033 4033
q2 320 227 218 218
q3 2912 2859 2795 2795
q4 1859 1538 1566 1538
q5 5147 5227 5169 5169
q6 196 122 116 116
q7 2240 1860 1833 1833
q8 3122 3265 3251 3251
q9 8473 8480 8476 8476
q10 3663 3672 3664 3664
q11 529 451 432 432
q12 745 579 536 536
q13 16923 2852 2861 2852
q14 275 247 254 247
q15 486 453 450 450
q16 453 413 404 404
q17 1704 1482 1469 1469
q18 7413 7021 7064 7021
q19 1610 1538 1516 1516
q20 1895 1695 1690 1690
q21 4765 4712 4760 4712
q22 495 450 468 450
Total cold run time: 69279 ms
Total hot run time: 52872 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids)Fix Bug when grouping has same grouping set [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #32235:
URL: https://github.com/apache/doris/pull/32235#issuecomment-1997485447
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids)Fix Bug when grouping has same grouping set [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #32235:
URL: https://github.com/apache/doris/pull/32235#issuecomment-1996742998
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids)Fix Bug when grouping has same grouping set [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32235:
URL: https://github.com/apache/doris/pull/32235#issuecomment-1997554767
<details>
<summary>TPC-H: <b>Total hot run time: 38023 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 96ec08c2a35c97a88095561f45a5f6b5893fde29, data reload: false
------ Round 1 ----------------------------------
q1 17600 4205 4067 4067
q2 2033 162 148 148
q3 10604 1081 896 896
q4 7782 701 685 685
q5 7487 2681 2754 2681
q6 186 121 129 121
q7 1153 806 805 805
q8 9418 1991 1950 1950
q9 7127 6457 6413 6413
q10 8495 3489 3605 3489
q11 433 220 219 219
q12 762 282 285 282
q13 18054 2831 2866 2831
q14 282 240 258 240
q15 504 458 454 454
q16 495 384 389 384
q17 947 519 605 519
q18 7161 6429 6368 6368
q19 1535 1430 1426 1426
q20 534 284 269 269
q21 6035 3481 3570 3481
q22 357 295 325 295
Total cold run time: 108984 ms
Total hot run time: 38023 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4093 4078 4057 4057
q2 319 223 216 216
q3 2957 2845 2790 2790
q4 1831 1643 1564 1564
q5 5186 5209 5223 5209
q6 197 115 114 114
q7 2251 1900 1871 1871
q8 3126 3271 3266 3266
q9 8548 8555 8570 8555
q10 3678 3680 3683 3680
q11 536 447 456 447
q12 703 533 562 533
q13 16947 2863 2865 2863
q14 280 242 260 242
q15 483 451 441 441
q16 433 396 386 386
q17 1737 1460 1443 1443
q18 7401 7122 7147 7122
q19 1618 1478 1545 1478
q20 1897 1730 1689 1689
q21 4873 4691 4655 4655
q22 496 442 458 442
Total cold run time: 69590 ms
Total hot run time: 53063 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids)Fix Bug when grouping has same grouping set [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32235:
URL: https://github.com/apache/doris/pull/32235#issuecomment-1996731214
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids)Fix Bug when grouping has same grouping set [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32235:
URL: https://github.com/apache/doris/pull/32235#issuecomment-1998918834
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids)Fix Bug when grouping has same grouping set [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #32235:
URL: https://github.com/apache/doris/pull/32235#issuecomment-1997446638
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids)Fix Bug when grouping has same grouping set [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #32235:
URL: https://github.com/apache/doris/pull/32235#discussion_r1524445530
##########
docs/zh-CN/community/design/grouping_sets_design.md:
##########
@@ -458,7 +458,7 @@ SELECT k1, k2, GROUPING_ID(k1,k2), SUM(k3) FROM t GROUP BY GROUPING SETS ((k1, k
```
-可以看到，其结果与对 GROUPING SETS 子句后每个子集进行 GROUP BY 后再进行 UNION 的结果一致。
+可以看到，其结果与对 GROUPING SETS 子句后每个子集进行 GROUP BY 后再进行 UNION ALL的结果一致。
Review Comment:
```suggestion
可以看到，其结果与对 GROUPING SETS 子句后每个子集进行 GROUP BY 后再进行 UNION ALL 的结果一致。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids)Fix Bug when grouping has same grouping set [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32235:
URL: https://github.com/apache/doris/pull/32235#issuecomment-1996850915
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids)Fix Bug when grouping has same grouping set [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32235:
URL: https://github.com/apache/doris/pull/32235#issuecomment-1996851041
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids)Fix Bug when grouping has same grouping set [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #32235:
URL: https://github.com/apache/doris/pull/32235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org