You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flume.apache.org by Israel Ekpo <is...@aicer.org> on 2013/04/06 14:17:04 UTC

Eclipse Code Formatting Guidelines for Apache Flume Source Code

I wanted to check if this is the current code formatting standards for the
project:

https://cwiki.apache.org/confluence/display/FLUME/Code+Formatting

https://cwiki.apache.org/confluence/download/attachments/27850532/eclipse-format.xml

I stumbled upon the link while reviewing other information in the wiki

If there are any other recent changes since the initial upload in June 2012
please let me know.

I just wanted to make sure that I am up to date with the coding standards

Some of my earlier patches had formatting issues as pointed out during the
reviews and I would like to prevent that in subsequent, future patches
submitted.

Re: Eclipse Code Formatting Guidelines for Apache Flume Source Code

Posted by Israel Ekpo <is...@aicer.org>.

Thanks Hari.

I think I would publish this on the project wiki for future references



On 6 April 2013 14:39, Hari Shreedharan <hs...@cloudera.com> wrote:

> I try to just follow these 4 rules:
>
> 1. Lines strictly <= 80 chars
> 2. No tabs and trailing whitespace
> 3. Intent - 2 spaces.
> 4. All if/for etc. have curly braces, even if it is just one line and
> starting curly braces appear after the if/for/while/try etc in the same
> line.
>
> You can configure most IDEs to do this automatically for you.
>
> Hari
>
> --
> Hari Shreedharan
>
>
> On Saturday, April 6, 2013 at 5:17 AM, Israel Ekpo wrote:
>
> > I wanted to check if this is the current code formatting standards for
> the
> > project:
> >
> > https://cwiki.apache.org/confluence/display/FLUME/Code+Formatting
> >
> >
> https://cwiki.apache.org/confluence/download/attachments/27850532/eclipse-format.xml
> >
> > I stumbled upon the link while reviewing other information in the wiki
> >
> > If there are any other recent changes since the initial upload in June
> 2012
> > please let me know.
> >
> > I just wanted to make sure that I am up to date with the coding standards
> >
> > Some of my earlier patches had formatting issues as pointed out during
> the
> > reviews and I would like to prevent that in subsequent, future patches
> > submitted.
> >
> >
>
>
>

Re: Eclipse Code Formatting Guidelines for Apache Flume Source Code

Posted by Hari Shreedharan <hs...@cloudera.com>.

I try to just follow these 4 rules: 

1. Lines strictly <= 80 chars
2. No tabs and trailing whitespace
3. Intent - 2 spaces.
4. All if/for etc. have curly braces, even if it is just one line and starting curly braces appear after the if/for/while/try etc in the same line.

You can configure most IDEs to do this automatically for you.

Hari 

-- 
Hari Shreedharan

On Saturday, April 6, 2013 at 5:17 AM, Israel Ekpo wrote:

> I wanted to check if this is the current code formatting standards for the
> project:
> 
> https://cwiki.apache.org/confluence/display/FLUME/Code+Formatting
> 
> https://cwiki.apache.org/confluence/download/attachments/27850532/eclipse-format.xml
> 
> I stumbled upon the link while reviewing other information in the wiki
> 
> If there are any other recent changes since the initial upload in June 2012
> please let me know.
> 
> I just wanted to make sure that I am up to date with the coding standards
> 
> Some of my earlier patches had formatting issues as pointed out during the
> reviews and I would like to prevent that in subsequent, future patches
> submitted.
> 
>