You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Erwan de FERRIERES (JIRA)" <ji...@apache.org> on 2009/08/27 17:28:59 UTC
[jira] Created: (OFBIZ-2874) improvement on human res leave
management
improvement on human res leave management
-----------------------------------------
Key: OFBIZ-2874
URL: https://issues.apache.org/jira/browse/OFBIZ-2874
Project: OFBiz
Issue Type: Improvement
Components: humanres
Affects Versions: SVN trunk
Reporter: Erwan de FERRIERES
Priority: Minor
Fix For: SVN trunk
Attachments: OFBIZ-2874.diff
For the moment in ofbiz, we only have the possibility to create leaves.
this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2874) improvement on human res leave
management
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya reassigned OFBIZ-2874:
------------------------------------------
Assignee: (was: Ashish Vijaywargiya)
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: leaveCalendar.png, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, partyProfile.png
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2874) improvement on human res leave
management
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760184#action_12760184 ]
Erwan de FERRIERES commented on OFBIZ-2874:
-------------------------------------------
Hi Jacques,
I agree totally. Just waiting for the moment !
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: leaveCalendar.png, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, partyProfile.png
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2874) improvement on human res leave
management
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752513#action_12752513 ]
Ashish Vijaywargiya commented on OFBIZ-2874:
--------------------------------------------
Thanks Erwan for the patch.
I would not be able to get back to this soon so keeping it unassigned once again.
May be someone else will pick and commit it soon. Jacques? :-)
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: leaveCalendar.png, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, partyProfile.png
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2874) improvement on human res leave
management
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760006#action_12760006 ]
Jacques Le Roux commented on OFBIZ-2874:
----------------------------------------
Hi Erwan,
I think we should provide status transtions (StatusValidChange) in HumanResDemoData.xml
Thanks
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: leaveCalendar.png, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, partyProfile.png
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2874) improvement on human res leave
management
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwan de FERRIERES updated OFBIZ-2874:
--------------------------------------
Attachment: OFBIZ-2874.diff
forgot to include 2 files... This patch will correct the previous
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: leaveCalendar.png, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, partyProfile.png
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2874) improvement on human res leave
management
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwan de FERRIERES updated OFBIZ-2874:
--------------------------------------
Attachment: OFBIZ-2874.diff
updated patch with no tabs
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: leaveCalendar.png, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, partyProfile.png
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2874) improvement on human res leave
management
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwan de FERRIERES updated OFBIZ-2874:
--------------------------------------
Attachment: (was: OFBIZ-2874.diff)
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2874.diff
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2874) improvement on human res leave
management
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwan de FERRIERES updated OFBIZ-2874:
--------------------------------------
Attachment: partyProfile.png
OFBIZ-2874.diff
this new patch adds a block in the EmployeeProfile which list the employee leaves
I've attached screenshots of the leave calendar and the leave block
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: leaveCalendar.png, OFBIZ-2874.diff, OFBIZ-2874.diff, partyProfile.png
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2874) improvement on human res leave
management
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwan de FERRIERES updated OFBIZ-2874:
--------------------------------------
Attachment: OFBIZ-2874.diff
this new patch adds a calendar of all the leaves taken for the partys with a roleTypeId = EMPLOYEE
from the type of the leave (requested, cancelled, etc...), the color will be different.
It shows month per month the leaves and only the employees with leaves.
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2874.diff
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2874) improvement on human res leave
management
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760039#action_12760039 ]
Jacques Le Roux commented on OFBIZ-2874:
----------------------------------------
Erwan,
So do you aggree that we set this issue as a duplicate of OFBIZ-2938 (it's better to not put the all link in Jira comment as Jira is then able to do more "things" with it, like showing it closed with understorke) ? You may then open a new Jira issue when OFBIZ-2938 will be commited.
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: leaveCalendar.png, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, partyProfile.png
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2874) improvement on human res leave
management
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwan de FERRIERES updated OFBIZ-2874:
--------------------------------------
Attachment: OFBIZ-2874.diff
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2874.diff
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2874) improvement on human res leave
management
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwan de FERRIERES updated OFBIZ-2874:
--------------------------------------
Attachment: OFBIZ-2874.diff
Hi Ashish,
here is a new version of the patch, with the improvements you've been suggesting.
Hope this one will meet your expectations !
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2874.diff
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2874) improvement on human res leave
management
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752130#action_12752130 ]
Ashish Vijaywargiya commented on OFBIZ-2874:
--------------------------------------------
Please remove the tabs from your patch and provide the updated patch.
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: leaveCalendar.png, OFBIZ-2874.diff, OFBIZ-2874.diff, partyProfile.png
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2874) improvement on human res leave
management
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwan de FERRIERES updated OFBIZ-2874:
--------------------------------------
Attachment: leaveCalendar.png
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: leaveCalendar.png, OFBIZ-2874.diff
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2874) improvement on human res leave
management
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwan de FERRIERES updated OFBIZ-2874:
--------------------------------------
Attachment: (was: OFBIZ-2874.diff)
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2874.diff
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2874) improvement on human res leave
management
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749237#action_12749237 ]
Ashish Vijaywargiya commented on OFBIZ-2874:
--------------------------------------------
Hello Erwan,
Thanks for your work on this.
Here are my comments on your work before it become part of trunk.
1) There is no need to create new tab by name "Validate leaves".
2) Remove both the forms and screen definition that you have created "ValidateEmplLeave" & "EditLeaveStatus".
3) Instead of this use Find Leave form and make it functional.
3a) What you need to do here is only make the list form shown at the bottom on Find Leave form functional and add combo for Status.
After doing this changes you will be done from this work.
4) Also in the entity changes create the foreign key relationship with the StatusItem entity.
--
Ashish
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2874.diff
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2874) improvement on human res leave
management
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-2874.
----------------------------------
Resolution: Duplicate
Assignee: Jacques Le Roux
Duplicate of OFBIZ-2938
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: leaveCalendar.png, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, partyProfile.png
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2874) improvement on human res leave
management
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760021#action_12760021 ]
Erwan de FERRIERES commented on OFBIZ-2874:
-------------------------------------------
Hi Jacques,
I'm waiting for this issue : https://issues.apache.org/jira/browse/OFBIZ-2938 to be reviewed and commited.
As I've seen with Pradeep, his patch is better than mine, and I'm more thinking of adapting the calendar provided here to his work.
> improvement on human res leave management
> -----------------------------------------
>
> Key: OFBIZ-2874
> URL: https://issues.apache.org/jira/browse/OFBIZ-2874
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: leaveCalendar.png, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, OFBIZ-2874.diff, partyProfile.png
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / rejected / accepted / cancelled).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.