[GitHub] [beam] y1chi commented on a change in pull request #16143: Avoid overriding explicit portable job submission disabling.

[GitBox <gi...@apache.org>]

y1chi commented on a change in pull request #16143:
URL: https://github.com/apache/beam/pull/16143#discussion_r763491532



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -595,7 +595,10 @@ def _maybe_add_unified_worker_missing_options(self, options):
       if not debug_options.lookup_experiment('disable_runner_v2'):
         debug_options.add_experiment('beam_fn_api')
         debug_options.add_experiment('use_runner_v2')
-        debug_options.add_experiment('use_portable_job_submission')
+        if (not debug_options.lookup_experiment('use_portable_job_submission')

Review comment:
       `not debug_options.lookup_experiment('use_portable_job_submission')` seems unnecessary since debug_options.add_experiment checks duplicates.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org